Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6275)

Unified Diff: chrome/browser/ui/android/page_info/website_settings_popup_android.h

Issue 2754383004: Rename WebsiteSettings code to PageInfo. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/page_info/website_settings_popup_android.h
diff --git a/chrome/browser/ui/android/page_info/website_settings_popup_android.h b/chrome/browser/ui/android/page_info/website_settings_popup_android.h
index c7e2a0d57d458495ad8ae2a78289a10f55557bf8..b2dab7b4d4d11b854f9404b176d55e5bab13274f 100644
--- a/chrome/browser/ui/android/page_info/website_settings_popup_android.h
+++ b/chrome/browser/ui/android/page_info/website_settings_popup_android.h
@@ -11,7 +11,7 @@
#include "base/android/scoped_java_ref.h"
#include "base/macros.h"
-#include "chrome/browser/ui/page_info/website_settings_ui.h"
+#include "chrome/browser/ui/page_info/page_info_ui.h"
namespace content {
class WebContents;
@@ -31,19 +31,18 @@ enum PageInfoConnectionType {
};
// Android implementation of the website settings UI.
estark 2017/03/20 20:19:17 ditto
-class WebsiteSettingsPopupAndroid : public WebsiteSettingsUI {
+class WebsiteSettingsPopupAndroid : public PageInfoUI {
estark 2017/03/20 20:19:17 Shouldn't this be renamed to PageInfoPopupAndroid?
lgarron 2017/03/20 23:09:03 I wanted to avoid doing Android in this CL, but it
public:
WebsiteSettingsPopupAndroid(JNIEnv* env,
jobject java_website_settings,
content::WebContents* web_contents);
~WebsiteSettingsPopupAndroid() override;
void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
- void RecordWebsiteSettingsAction(
- JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- jint action);
+ void RecordPageInfoAction(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jint action);
- // WebsiteSettingsUI implementations.
+ // PageInfoUI implementations.
void SetCookieInfo(const CookieInfoList& cookie_info_list) override;
void SetPermissionInfo(const PermissionInfoList& permission_info_list,
ChosenObjectInfoList chosen_object_info_list) override;
@@ -53,7 +52,7 @@ class WebsiteSettingsPopupAndroid : public WebsiteSettingsUI {
private:
// The presenter that controlls the Website Settings UI.
- std::unique_ptr<WebsiteSettings> presenter_;
+ std::unique_ptr<PageInfo> presenter_;
// The java prompt implementation.
base::android::ScopedJavaGlobalRef<jobject> popup_jobject_;

Powered by Google App Engine
This is Rietveld 408576698