OfflineContentProvider changes to start service

components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/ContentId.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.components.offline_items_collection;
 
 /**
  * This class is a Java counterpart to the C++ ContentId
  * (components/offline_items_collection/core/offline_item.h) class.
  *
  * For all member variable descriptions see the C++ class.
  * TODO(dtrainor): Investigate making all class members for this and the C++ counterpart const.
  */
 public class ContentId {
     public String namespace;

[qinmin, 2017/03/22 07:53:58]

nit: public final

     public String id;
 
     public ContentId() {}
     public ContentId(String namespace, String id) {
         this.namespace = namespace;
         this.id = id;
     }
+

[gone, 2017/03/20 19:03:36]

Also randomly added?

[David Trainor- moved to gerrit, 2017/03/25 03:31:13]

See comment in OfflineItem.java.

+    @Override
+    public String toString() {
+        return getClass().getSimpleName() + "@" + Integer.toHexString(hashCode()) + " [" + namespace
+                + ", " + id + "]";
+    }
+
+    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (!(o instanceof ContentId)) return false;
+
+        ContentId lhs = (ContentId) o;

[fgorski, 2017/03/20 20:19:20]

rhs?
Both because this is right of equals and you put it on the right below.

[David Trainor- moved to gerrit, 2017/03/25 03:31:13]

Done.

+        return namespace == lhs.namespace && id == lhs.id;
+    }
+
+    @Override
+    public int hashCode() {
+        int result = 61;
+
+        result = 31 * result + (namespace == null ? 0 : namespace.hashCode());
+        result = 31 * result + (id == null ? 0 : id.hashCode());
+
+        return result;
+    }
 }