Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart

Issue 2754343002: Tweak message. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.kernel_class_builder; 5 library fasta.kernel_class_builder;
6 6
7 import 'package:kernel/ast.dart' 7 import 'package:kernel/ast.dart'
8 show 8 show
9 Class, 9 Class,
10 Constructor, 10 Constructor,
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 "The method '$name::${declaredMember.name.name}' has fewer " 223 "The method '$name::${declaredMember.name.name}' has fewer "
224 "positional arguments than those of overridden method " 224 "positional arguments than those of overridden method "
225 "'${interfaceMember.enclosingClass.name}::" 225 "'${interfaceMember.enclosingClass.name}::"
226 "${interfaceMember.name.name}'."); 226 "${interfaceMember.name.name}'.");
227 } 227 }
228 if (interfaceFunction.requiredParameterCount < 228 if (interfaceFunction.requiredParameterCount <
229 declaredFunction.requiredParameterCount) { 229 declaredFunction.requiredParameterCount) {
230 addWarning( 230 addWarning(
231 declaredMember.fileOffset, 231 declaredMember.fileOffset,
232 "The method '$name::${declaredMember.name.name}' has more " 232 "The method '$name::${declaredMember.name.name}' has more "
233 "positional arguments than those of overridden method " 233 "required arguments than those of overridden method "
234 "'${interfaceMember.enclosingClass.name}::" 234 "'${interfaceMember.enclosingClass.name}::"
235 "${interfaceMember.name.name}'."); 235 "${interfaceMember.name.name}'.");
236 } 236 }
237 if (declaredFunction.namedParameters.isEmpty && 237 if (declaredFunction.namedParameters.isEmpty &&
238 interfaceFunction.namedParameters.isEmpty) { 238 interfaceFunction.namedParameters.isEmpty) {
239 return; 239 return;
240 } 240 }
241 if (declaredFunction.namedParameters.length < 241 if (declaredFunction.namedParameters.length <
242 interfaceFunction.namedParameters.length) { 242 interfaceFunction.namedParameters.length) {
243 addWarning( 243 addWarning(
(...skipping 30 matching lines...) Expand all
274 } 274 }
275 275
276 void addWarning(int charOffset, String message) { 276 void addWarning(int charOffset, String message) {
277 library.addWarning(charOffset, message, fileUri: fileUri); 277 library.addWarning(charOffset, message, fileUri: fileUri);
278 } 278 }
279 279
280 void addNit(int charOffset, String message) { 280 void addNit(int charOffset, String message) {
281 library.addNit(charOffset, message, fileUri: fileUri); 281 library.addNit(charOffset, message, fileUri: fileUri);
282 } 282 }
283 } 283 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698