Issue 275433011: Regression(r169412): Fix serialization of frame / iframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 275433011: Regression(r169412): Fix serialization of frame / iframe (Closed)

Created:
6 years, 7 months ago by Inactive

Modified:
6 years, 7 months ago

Reviewers:
tkent, adamk

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Regression(r169412): Fix serialization of frame / iframe The frame / iframe src attribute value was not correctly updated upon serializing because HTMLFrameElementBase::hasLegalLinkAttribute() was returning true if the attribute name was 'href' instead of 'src'. The attribute was thus not detected as a link attribute and its value was not correctly updated with the path to the serialized frame. R=tkent@chromium.org, adamk@chromium.org BUG=370772 TEST=WebPageNewSerializeTest.SubFrameSerialization Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173686

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -1 line)			Patch
	M	Source/core/html/HTMLFrameElementBase.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/web/tests/WebPageNewSerializerTest.cpp	View		2 chunks	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/275433011/1

6 years, 7 months ago (2014-05-08 21:15:20 UTC) #3

Message was sent while issue was closed.

Change committed as 173686

Expand Messages | Collapse Messages