Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 275433007: Update window resize tests (Closed)

Created:
6 years, 7 months ago by Xianzhu
Modified:
6 years, 7 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Update window resize tests - fixed two tests containing unrelated percentage width. - added body margin:0 for some tests containing percentage lengths to make the results more readable after we optimize window resize repaint. - made result of window-resize-viewport-percent.html platform independent. BUG=258219 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173907

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Use maybe better method #

Patch Set 4 : Update test cases to make expected results more readable #

Patch Set 5 : Rebased on https://codereview.chromium.org/277573003/ #

Messages

Total messages: 12 (0 generated)
Xianzhu
6 years, 7 months ago (2014-05-07 18:18:14 UTC) #1
Xianzhu
Please wait a minute. Will upload a new patch set using a better method.
6 years, 7 months ago (2014-05-07 18:28:18 UTC) #2
Xianzhu
It's ready. PTAL.
6 years, 7 months ago (2014-05-07 18:58:38 UTC) #3
Xianzhu
6 years, 7 months ago (2014-05-08 16:29:19 UTC) #4
Xianzhu
6 years, 7 months ago (2014-05-09 17:30:49 UTC) #5
Xianzhu
Rebased on https://codereview.chromium.org/277573003/. PTAL.
6 years, 7 months ago (2014-05-12 17:02:46 UTC) #6
enne (OOO)
lgtm, thanks. Sorry for stepping on your toes!
6 years, 7 months ago (2014-05-12 17:45:29 UTC) #7
Xianzhu
On 2014/05/12 17:45:29, enne wrote: > lgtm, thanks. Sorry for stepping on your toes! No ...
6 years, 7 months ago (2014-05-12 17:49:27 UTC) #8
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-05-12 17:49:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/275433007/90001
6 years, 7 months ago (2014-05-12 17:49:43 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 19:11:36 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 20:25:27 UTC) #12
Message was sent while issue was closed.
Change committed as 173907

Powered by Google App Engine
This is Rietveld 408576698