Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 275433002: Turn CHECK()s into ASSERT()s. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
As discussed offline... PTAL
6 years, 7 months ago (2014-05-07 08:37:21 UTC) #1
Michael Achenbach
lgtm
6 years, 7 months ago (2014-05-07 08:41:19 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-07 08:42:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21187 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698