Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSheetContent.java

Issue 2754313002: [Home] Record some user actions for the Chrome Home BottomSheet (Closed)
Patch Set: Move early return to BottomSheet Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.bookmarks; 5 package org.chromium.chrome.browser.bookmarks;
6 6
7 import android.support.v7.widget.Toolbar; 7 import android.support.v7.widget.Toolbar;
8 import android.view.View; 8 import android.view.View;
9 9
10 import org.chromium.chrome.browser.ChromeActivity; 10 import org.chromium.chrome.browser.ChromeActivity;
11 import org.chromium.chrome.browser.UrlConstants; 11 import org.chromium.chrome.browser.UrlConstants;
12 import org.chromium.chrome.browser.toolbar.BottomToolbarPhone; 12 import org.chromium.chrome.browser.toolbar.BottomToolbarPhone;
13 import org.chromium.chrome.browser.widget.bottomsheet.BottomSheet.BottomSheetCon tent; 13 import org.chromium.chrome.browser.widget.bottomsheet.BottomSheet.BottomSheetCon tent;
14 import org.chromium.chrome.browser.widget.bottomsheet.BottomSheetContentControll er;
14 15
15 /** 16 /**
16 * A {@link BottomSheetContent} holding a {@link BookmarkManager} for display in the BottomSheet. 17 * A {@link BottomSheetContent} holding a {@link BookmarkManager} for display in the BottomSheet.
17 */ 18 */
18 public class BookmarkSheetContent implements BottomSheetContent { 19 public class BookmarkSheetContent implements BottomSheetContent {
19 private final View mContentView; 20 private final View mContentView;
20 private final Toolbar mToolbarView; 21 private final Toolbar mToolbarView;
21 private BookmarkManager mBookmarkManager; 22 private BookmarkManager mBookmarkManager;
22 23
23 /** 24 /**
(...skipping 21 matching lines...) Expand all
45 @Override 46 @Override
46 public int getVerticalScrollOffset() { 47 public int getVerticalScrollOffset() {
47 return mBookmarkManager.getVerticalScrollOffset(); 48 return mBookmarkManager.getVerticalScrollOffset();
48 } 49 }
49 50
50 @Override 51 @Override
51 public void destroy() { 52 public void destroy() {
52 mBookmarkManager.destroy(); 53 mBookmarkManager.destroy();
53 mBookmarkManager = null; 54 mBookmarkManager = null;
54 } 55 }
56
57 @Override
58 public int getType() {
gone 2017/03/20 20:29:31 Does it work if you try to annotate these with @Co
Theresa 2017/03/20 20:59:12 I added an annotation to the superclass method. Wi
gone 2017/03/20 21:04:52 super's probably cool. Hard to gauge where it sho
Theresa 2017/03/20 21:22:52 With the superclass annotation, Android Studio com
59 return BottomSheetContentController.TYPE_BOOKMARKS;
60 }
55 } 61 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698