Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2754233002: Revert "DWARF and unwind support for AOT assembly output." (Closed)

Created:
3 years, 9 months ago by eernst
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "DWARF and unwind support for AOT assembly output." Gardening. This reverts commit ca20aab38465ce5d5990987337c57650350af1f6. That commit causes generation of incorrect register names on vm-noopt-simarm64-mac-be, and it seems to cause a disk full error later on (making the bot purple). Committed: https://github.com/dart-lang/sdk/commit/8fcdbb4a7f4bc484fdef49422665e74d16770cb6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -1255 lines) Patch
M runtime/vm/assembler_arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M runtime/vm/dart.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/datastream.h View 2 chunks +22 lines, -23 lines 0 comments Download
D runtime/vm/dwarf.h View 1 chunk +0 lines, -207 lines 0 comments Download
D runtime/vm/dwarf.cc View 1 chunk +0 lines, -643 lines 0 comments Download
M runtime/vm/flag_list.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/flags.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/hash_map.h View 2 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/native_symbol.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/native_symbol_android.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M runtime/vm/native_symbol_fuchsia.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M runtime/vm/native_symbol_linux.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M runtime/vm/native_symbol_macos.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M runtime/vm/native_symbol_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 8 chunks +17 lines, -95 lines 0 comments Download
M runtime/vm/object_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 18 chunks +18 lines, -18 lines 0 comments Download
M runtime/vm/snapshot.h View 4 chunks +4 lines, -7 lines 0 comments Download
M runtime/vm/snapshot.cc View 10 chunks +54 lines, -161 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eernst
TBR. Gardening: Talked to Slava, now reverting Ryan's CL because it causes generation of wrong ...
3 years, 9 months ago (2017-03-17 11:55:45 UTC) #2
eernst
Committed patchset #1 (id:1) manually as 8fcdbb4a7f4bc484fdef49422665e74d16770cb6 (presubmit successful).
3 years, 9 months ago (2017-03-17 11:57:53 UTC) #4
rmacnak
On 2017/03/17 11:57:53, eernst wrote: > Committed patchset #1 (id:1) manually as > 8fcdbb4a7f4bc484fdef49422665e74d16770cb6 (presubmit ...
3 years, 9 months ago (2017-03-17 17:14:26 UTC) #5
eernst
3 years, 9 months ago (2017-03-17 17:17:33 UTC) #6
Message was sent while issue was closed.
On 2017/03/17 17:14:26, rmacnak wrote:
> On 2017/03/17 11:57:53, eernst wrote:
> > Committed patchset #1 (id:1) manually as
> > 8fcdbb4a7f4bc484fdef49422665e74d16770cb6 (presubmit successful).
> 
> The assembly code is right, but we're using the wrong toolchain. Sent a CL to
> update the bots to avoid this.

Thx!

Powered by Google App Engine
This is Rietveld 408576698