Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: telemetry/telemetry/internal/actions/action_runner_unittest.py

Issue 2754203005: touchpad swipe support added.
Patch Set: Comments on scroll and swipe directions. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/actions/action_runner_unittest.py
diff --git a/telemetry/telemetry/internal/actions/action_runner_unittest.py b/telemetry/telemetry/internal/actions/action_runner_unittest.py
index 1c4c25915d0dde8f055512d1fd31b993356f934f..51b3493af9367984ac134711a1f0ed32b01223f5 100644
--- a/telemetry/telemetry/internal/actions/action_runner_unittest.py
+++ b/telemetry/telemetry/internal/actions/action_runner_unittest.py
@@ -375,6 +375,9 @@ class ActionRunnerTest(tab_test_case.TabTestCase):
self.assertTrue(action_runner.EvaluateJavaScript(
'(document.scrollingElement || document.body).scrollLeft') > 75)
+ # TODO(sahel): Remove Disabled('all') when the swipe direction is updated.
+ # https://github.com/catapult-project/catapult/issues/3415
+ @decorators.Disabled('all')
@decorators.Disabled('android', # crbug.com/437065.
'chromeos') # crbug.com/483212.
def testSwipe(self):
@@ -387,15 +390,15 @@ class ActionRunnerTest(tab_test_case.TabTestCase):
skip_waits=True)
action_runner.SwipeElement(
- selector='#left-right', direction='left', left_start_ratio=0.9)
+ selector='#left-right', direction='right', left_start_ratio=0.9)
self.assertTrue(action_runner.EvaluateJavaScript(
'document.querySelector("#left-right").scrollLeft') > 75)
action_runner.SwipeElement(
- selector='#top-bottom', direction='up', top_start_ratio=0.9)
+ selector='#top-bottom', direction='down', top_start_ratio=0.9)
self.assertTrue(action_runner.EvaluateJavaScript(
'document.querySelector("#top-bottom").scrollTop') > 75)
- action_runner.SwipePage(direction='left', left_start_ratio=0.9)
+ action_runner.SwipePage(direction='right', left_start_ratio=0.9)
self.assertTrue(action_runner.EvaluateJavaScript(
'(document.scrollingElement || document.body).scrollLeft') > 75)

Powered by Google App Engine
This is Rietveld 408576698