chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java - Issue 2754103003: Adds metric to help assess last_n impact on tab restores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

Issue 2754103003: Adds metric to help assess last_n impact on tab restores. (Closed)

Patch Set: Removed canSaveUrl method because it was already implemented elsewhere. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | components/offline_pages/core/offline_page_model.cc » ('j') | components/offline_pages/core/offline_page_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

index 798d7727fe508152231434022cffbde9cf159dc0..743a991aee7d61b96092b016857aa6a7a5a0188f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

@@ -148,7 +148,7 @@ public class TabWebContentsObserver extends WebContentsObserver {

@Override

public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame) {

- if (isMainFrame) mTab.didFinishPageLoad();

+ if (isMainFrame) mTab.didFinishPageLoad(validatedUrl);

PolicyAuditor auditor = AppHooks.get().getPolicyAuditor();

auditor.notifyAuditEvent(

mTab.getApplicationContext(), AuditEvent.OPEN_URL_SUCCESS, validatedUrl, "");