tools/metrics/histograms/histograms.xml - Issue 2754103003: Adds metric to help assess last_n impact on tab restores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2754103003: Adds metric to help assess last_n impact on tab restores. (Closed)

Patch Set: Removed canSaveUrl method because it was already implemented elsewhere. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 35bf3ee00b5c96f35104ccaf8a92476c6e6b2fea..220ed24ac4a84ff45bed3457d5e6d533312523d0 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -43493,6 +43493,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="OfflinePages.TabRestore" enum="OfflinePagesTabRestoreType">

+ <owner>carlosk@chromium.org</owner>

+ <summary>

+ Tracks the reload of contents of an existing tab that is being restored

+ either because that tab is being presented for the first time after Chrome

+ was restarted or because its contents were discarded. All buckets are

+ mutually exclusive (adding up all reported values amounts to the total

+ number of tracked tab restores). This metric is focused on last_n offline

+ pages and is exclusive to Chrome on Android.

+ </summary>

+</histogram>

<owner>fgorski@chromium.org</owner>

<owner>jianli@chromium.org</owner>

@@ -103049,6 +103061,20 @@ from previous Chrome versions.

</enum>

+<enum name="OfflinePagesTabRestoreType" type="int">

+ <int value="0" label="WhileOnline"/>

fgorski 2017/03/17 03:42:51 This can have spaces and sentence case.

carlosk 2017/03/17 20:37:22 Done. Indeed much better! I also learned about and

+ <int value="1" label="WhileOnlineCouldBeSavedOffline"/>

+ <int value="2" label="WhileOnlineToOfflinePage"/>

+ <int value="3" label="WhileOnlineToOfflinePageFromLastN"/>

+ <int value="4" label="WhileOffline"/>

+ <int value="5" label="WhileOfflineCouldBeSavedOffline"/>

+ <int value="6" label="WhileOfflineToOfflinePage"/>

+ <int value="7" label="WhileOfflineToOfflinePageFromLastN"/>

+ <int value="8" label="Failed"/>

+ <int value="9" label="FailedToDinoPage"/>

+ <int value="10" label="Crashed"/>

+</enum>

Deprecated 4/2015.

« components/offline_pages/core/offline_page_model.cc ('K') | « components/offline_pages/core/offline_page_model.cc ('k') | no next file » | no next file with comments »