Mojo EDK: Circulate MojoArmWatcher outputs to avoid starvation

mojo/edk/system/watcher_dispatcher.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_EDK_SYSTEM_WATCHER_DISPATCHER_H_
 #define MOJO_EDK_SYSTEM_WATCHER_DISPATCHER_H_
 
 #include <map>
 #include <set>
 
@@ skipping 37 matching lines @@
                              uintptr_t context) override;
   MojoResult CancelWatch(uintptr_t context) override;
   MojoResult Arm(uint32_t* num_ready_contexts,
                  uintptr_t* ready_contexts,
                  MojoResult* ready_results,
                  MojoHandleSignalsState* ready_signals_states) override;
 
  private:
   friend class Watch;
 
+  using WatchSet = std::set<Watch*>;
+
   ~WatcherDispatcher() override;
 
   const MojoWatcherCallback callback_;
 
   // Guards access to the fields below.
   //
   // NOTE: This may be acquired while holding another dispatcher's lock, as
   // watched dispatchers call into WatcherDispatcher methods which lock this
   // when issuing state change notifications. WatcherDispatcher must therefore
   // take caution to NEVER acquire other dispatcher locks while this is held.
   base::Lock lock_;
 
   bool armed_ = false;
   bool closed_ = false;
 
   // A mapping from context to Watch.
   std::map<uintptr_t, scoped_refptr<Watch>> watches_;
 
   // A mapping from watched dispatcher to Watch.
   std::map<Dispatcher*, scoped_refptr<Watch>> watched_handles_;
 
   // The set of all Watch instances which are currently ready to signal. This is
   // used for efficient arming behavior, as it allows for O(1) discovery of
   // whether or not arming can succeed and quick determination of who's
   // responsible if it can't.
-  std::set<Watch*> ready_watches_;
+  WatchSet ready_watches_;
+
+  // Tracks the last Watch whose state was returned by Arm(). This is used to
+  // ensure consistent round-robin behavior in the event that multiple Watches
+  // remain ready over the span of several Arm() attempts.
+  Watch* last_watch_to_block_arming_ = nullptr;

[yzshen1, 2017/03/16 18:59:01]

Please comment that this pointer may not refer to a valid object and therefore
should never be de-refed. Or maybe change it to uintptr_t.

[Ken Rockot(use gerrit already), 2017/03/16 19:21:11]

Done

 
   DISALLOW_COPY_AND_ASSIGN(WatcherDispatcher);
 };
 
 }  // namespace edk
 }  // namespace mojo
 
 #endif  // MOJO_EDK_SYSTEM_WATCHER_DISPATCHER_H_