Fix the position of AutofillClient for PasswordAutofillManager when the focused form element is ins…

components/password_manager/content/browser/content_password_manager_driver.cc

Index: components/password_manager/content/browser/content_password_manager_driver.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc
index 52ed13007579d1974d1a7354d5dd9e8e9705274c..2918fa98d944dee664be902d7307304c471c1be7 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver.cc
@@ -20,6 +20,7 @@
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
+#include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/ssl_status.h"
 #include "content/public/browser/web_contents.h"
@@ -290,7 +291,11 @@ void ContentPasswordManagerDriver::ShowPasswordSuggestions(
 void ContentPasswordManagerDriver::ShowNotSecureWarning(
     base::i18n::TextDirection text_direction,
     const gfx::RectF& bounds) {
-  password_autofill_manager_.OnShowNotSecureWarning(text_direction, bounds);
+  content::RenderWidgetHostView* rwhv = render_frame_host_->GetView();

[EhsanK, 2017/03/16 07:06:58]

Not sure yet if |rwhv| can be nullptr.

[vabr (Chromium), 2017/03/16 08:25:49]

Looking at ContentAutofillDriver::TransformBoundingBoxToViewportCoordinates, the
null case should be handled.

[EhsanK, 2017/03/16 20:39:00]

Agreed. We should check. But not sure how this can happen. Maybe when we
navigate right after this is called by the renderer?

+  gfx::RectF transformed_bounds(
+      rwhv->TransformPointToRootCoordSpaceF(bounds.origin()), bounds.size());
+  password_autofill_manager_.OnShowNotSecureWarning(text_direction,

[EhsanK, 2017/03/16 06:47:33]

I looked to me better to apply the transform here as opposed to inside
AutofillClient. If I understand correctly, AutofillClient is page level so we
have to submit transformed points to it instead. WDYT?

[vabr (Chromium), 2017/03/16 08:25:49]

The browser process and the driver in particular seem like a good place to do
the transformation in, and it matches the non-password autofill
(ContentAutofillDriver::TransformBoundingBoxToViewportCoordinates).

[EhsanK, 2017/03/16 20:39:00]

Acknowledged.

+                                                    transformed_bounds);
 }
 
 void ContentPasswordManagerDriver::RecordSavePasswordProgress(