Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 275403004: Revert of Pepper: Clean up ProgressEvent logic. (Closed)

Created:
6 years, 7 months ago by hamaji
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Pepper: Clean up ProgressEvent logic. (https://codereview.chromium.org/270453004/) Reason for revert: This broke our app. We do not understand why the breakage happened or why browser_tests could not catch this yet. However, as our app do not want this in M36, I'd revert this change without checking. BUG=372163 Original issue's description: > Pepper: Clean up ProgressEvent logic. > > This simplifies NexeLoadManager, which is getting pretty big. This also removes > an unused field from ProgressEvent, and adds a convenience function for posting > a task to dispatch a progress event from the main thread, which is often > necessary to ensure that progress events are posted to the DOM after other > state changes. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269362 TBR=dmichael@chromium.org,teravest@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -176 lines) Patch
M components/nacl.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M components/nacl/renderer/nexe_load_manager.h View 1 chunk +25 lines, -0 lines 0 comments Download
M components/nacl/renderer/nexe_load_manager.cc View 11 chunks +120 lines, -19 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 2 chunks +36 lines, -7 lines 0 comments Download
D components/nacl/renderer/progress_event.h View 1 chunk +0 lines, -53 lines 0 comments Download
D components/nacl/renderer/progress_event.cc View 1 chunk +0 lines, -95 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hamaji
Created Revert of Pepper: Clean up ProgressEvent logic.
6 years, 7 months ago (2014-05-12 07:11:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hamaji@chromium.org/275403004/1
6 years, 7 months ago (2014-05-12 07:12:04 UTC) #2
commit-bot: I haz the power
Change committed as 269747
6 years, 7 months ago (2014-05-12 07:12:55 UTC) #3
teravest
6 years, 7 months ago (2014-05-12 14:04:54 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698