Prerender: omnibox and instant field trial parameters.

chrome/browser/prerender/prerender_field_trial.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PRERENDER_PRERENDER_FIELD_TRIAL_H_
 #define CHROME_BROWSER_PRERENDER_PRERENDER_FIELD_TRIAL_H_
 
 #include "base/feature_list.h"
 
 class Profile;
 
 namespace prerender {
 
 extern const base::Feature kNoStatePrefetchFeature;
 extern const char kNoStatePrefetchFeatureModeParameterName[];
+extern const char kNoStatePrefetchFeatureInstantModeParameterName[];

[pasko, 2017/03/17 17:33:33]

nit: maybe add a comment that these are exposed outside the .cc for testing
only? I'd actually prefer to duplicate the strings in the tests, but it's better
be done later.

[mattcary, 2017/03/20 10:20:31]

Done.

I go both ways on duplicating strings in the tests. 

+extern const char kNoStatePrefetchFeatureOmniboxModeParameterName[];
 extern const char kNoStatePrefetchFeatureModeParameterPrefetch[];
 extern const char kNoStatePrefetchFeatureModeParameterPrerender[];
 extern const char kNoStatePrefetchFeatureModeParameterSimpleLoad[];
+extern const char kNoStatePrefetchFeatureModeParameterDisabled[];
 
 // Configures prerender using kNoStatePrefetchFeature and field trial
 // parameters.
 void ConfigurePrerender();
 
 // Returns true if the user has opted in or has been opted in to the
 // prerendering from Omnibox experiment.
 bool IsOmniboxEnabled(Profile* profile);
 
 }  // namespace prerender
 
 #endif  // CHROME_BROWSER_PRERENDER_PRERENDER_FIELD_TRIAL_H_