Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 2754003003: Disable flaky tests in Chrome OS file manager. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/chromeos/drive/file_system_util.h" 9 #include "chrome/browser/chromeos/drive/file_system_util.h"
10 #include "chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h" 10 #include "chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h"
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 WRAPPED_INSTANTIATE_TEST_CASE_P( 189 WRAPPED_INSTANTIATE_TEST_CASE_P(
190 DISABLED_QuickView, 190 DISABLED_QuickView,
191 FileManagerBrowserTest, 191 FileManagerBrowserTest,
192 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "openQuickView"))); 192 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "openQuickView")));
193 193
194 #if defined(DISABLE_SLOW_FILESAPP_TESTS) 194 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
195 #define MAYBE_DirectoryTreeContextMenu DISABLED_DirectoryTreeContextMenu 195 #define MAYBE_DirectoryTreeContextMenu DISABLED_DirectoryTreeContextMenu
196 #else 196 #else
197 #define MAYBE_DirectoryTreeContextMenu DirectoryTreeContextMenu 197 #define MAYBE_DirectoryTreeContextMenu DirectoryTreeContextMenu
198 #endif 198 #endif
199 // Flaky: crbug.com/700156, crbug.com/699083
199 WRAPPED_INSTANTIATE_TEST_CASE_P( 200 WRAPPED_INSTANTIATE_TEST_CASE_P(
200 DISABLED_DirectoryTreeContextMenu, 201 DISABLED_DirectoryTreeContextMenu,
201 FileManagerBrowserTest, 202 FileManagerBrowserTest,
202 ::testing::Values( 203 ::testing::Values(
203 TestParameter(NOT_IN_GUEST_MODE, 204 TestParameter(NOT_IN_GUEST_MODE,
204 "copyFromDirectoryTreeWithContextMenu"), 205 "copyFromDirectoryTreeWithContextMenu"),
205 TestParameter(IN_GUEST_MODE, "copyFromDirectoryTreeWithContextMenu"), 206 TestParameter(IN_GUEST_MODE, "copyFromDirectoryTreeWithContextMenu"),
206 TestParameter(NOT_IN_GUEST_MODE, 207 TestParameter(NOT_IN_GUEST_MODE,
207 "copyFromDirectoryTreeWithKeyboardShortcut"), 208 "copyFromDirectoryTreeWithKeyboardShortcut"),
208 TestParameter(IN_GUEST_MODE, 209 TestParameter(IN_GUEST_MODE,
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 TestParameter(NOT_IN_GUEST_MODE, 251 TestParameter(NOT_IN_GUEST_MODE,
251 "createDirectoryFromDirectoryTreeWithoutChangingCurrentDi" 252 "createDirectoryFromDirectoryTreeWithoutChangingCurrentDi"
252 "rectory"))); 253 "rectory")));
253 254
254 // Fails on official build. http://crbug.com/429294 255 // Fails on official build. http://crbug.com/429294
255 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD) 256 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
256 #define MAYBE_DriveSpecific DISABLED_DriveSpecific 257 #define MAYBE_DriveSpecific DISABLED_DriveSpecific
257 #else 258 #else
258 #define MAYBE_DriveSpecific DriveSpecific 259 #define MAYBE_DriveSpecific DriveSpecific
259 #endif 260 #endif
261 // Flaky: crbug.com/698834
260 WRAPPED_INSTANTIATE_TEST_CASE_P( 262 WRAPPED_INSTANTIATE_TEST_CASE_P(
261 MAYBE_DriveSpecific, 263 DISABLED_DriveSpecific,
262 FileManagerBrowserTest, 264 FileManagerBrowserTest,
263 ::testing::Values( 265 ::testing::Values(
264 TestParameter(NOT_IN_GUEST_MODE, "openSidebarRecent"), 266 TestParameter(NOT_IN_GUEST_MODE, "openSidebarRecent"),
265 TestParameter(NOT_IN_GUEST_MODE, "openSidebarOffline"), 267 TestParameter(NOT_IN_GUEST_MODE, "openSidebarOffline"),
266 TestParameter(NOT_IN_GUEST_MODE, "openSidebarSharedWithMe"), 268 TestParameter(NOT_IN_GUEST_MODE, "openSidebarSharedWithMe"),
267 TestParameter(NOT_IN_GUEST_MODE, "autocomplete"), 269 TestParameter(NOT_IN_GUEST_MODE, "autocomplete"),
268 TestParameter(NOT_IN_GUEST_MODE, "pinFileOnMobileNetwork"), 270 TestParameter(NOT_IN_GUEST_MODE, "pinFileOnMobileNetwork"),
269 TestParameter(NOT_IN_GUEST_MODE, "clickFirstSearchResult"), 271 TestParameter(NOT_IN_GUEST_MODE, "clickFirstSearchResult"),
270 TestParameter(NOT_IN_GUEST_MODE, "pressEnterToSearch"))); 272 TestParameter(NOT_IN_GUEST_MODE, "pressEnterToSearch")));
271 273
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 DISABLE_SuggestAppDialog, 350 DISABLE_SuggestAppDialog,
349 FileManagerBrowserTest, 351 FileManagerBrowserTest,
350 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "suggestAppDialog"))); 352 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "suggestAppDialog")));
351 353
352 #if defined(DISABLE_SLOW_FILESAPP_TESTS) 354 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
353 #define MAYBE_ExecuteDefaultTaskOnDownloads \ 355 #define MAYBE_ExecuteDefaultTaskOnDownloads \
354 DISABLED_ExecuteDefaultTaskOnDownloads 356 DISABLED_ExecuteDefaultTaskOnDownloads
355 #else 357 #else
356 #define MAYBE_ExecuteDefaultTaskOnDownloads ExecuteDefaultTaskOnDownloads 358 #define MAYBE_ExecuteDefaultTaskOnDownloads ExecuteDefaultTaskOnDownloads
357 #endif 359 #endif
360 // Flaky: crbug.com/699171
358 WRAPPED_INSTANTIATE_TEST_CASE_P( 361 WRAPPED_INSTANTIATE_TEST_CASE_P(
359 MAYBE_ExecuteDefaultTaskOnDownloads, 362 DISABLED_ExecuteDefaultTaskOnDownloads,
360 FileManagerBrowserTest, 363 FileManagerBrowserTest,
361 ::testing::Values( 364 ::testing::Values(
362 TestParameter(NOT_IN_GUEST_MODE, "executeDefaultTaskOnDownloads"), 365 TestParameter(NOT_IN_GUEST_MODE, "executeDefaultTaskOnDownloads"),
363 TestParameter(IN_GUEST_MODE, "executeDefaultTaskOnDownloads"))); 366 TestParameter(IN_GUEST_MODE, "executeDefaultTaskOnDownloads")));
364 367
365 #if defined(DISABLE_SLOW_FILESAPP_TESTS) 368 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
366 #define MAYBE_ExecuteDefaultTaskOnDrive DISABLED_ExecuteDefaultTaskOnDrive 369 #define MAYBE_ExecuteDefaultTaskOnDrive DISABLED_ExecuteDefaultTaskOnDrive
367 #else 370 #else
368 #define MAYBE_ExecuteDefaultTaskOnDrive ExecuteDefaultTaskOnDrive 371 #define MAYBE_ExecuteDefaultTaskOnDrive ExecuteDefaultTaskOnDrive
369 #endif 372 #endif
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 WRAPPED_INSTANTIATE_TEST_CASE_P( 444 WRAPPED_INSTANTIATE_TEST_CASE_P(
442 MAYBE_TabindexFocus, 445 MAYBE_TabindexFocus,
443 FileManagerBrowserTestWithLegacyEventDispatch, 446 FileManagerBrowserTestWithLegacyEventDispatch,
444 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "tabindexFocus"))); 447 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "tabindexFocus")));
445 448
446 #if defined(DISABLE_SLOW_FILESAPP_TESTS) 449 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
447 #define MAYBE_TabindexFocusDownloads DISABLED_TabindexFocusDownloads 450 #define MAYBE_TabindexFocusDownloads DISABLED_TabindexFocusDownloads
448 #else 451 #else
449 #define MAYBE_TabindexFocusDownloads TabindexFocusDownloads 452 #define MAYBE_TabindexFocusDownloads TabindexFocusDownloads
450 #endif 453 #endif
454 // Flaky: crbug.com/699534
451 WRAPPED_INSTANTIATE_TEST_CASE_P( 455 WRAPPED_INSTANTIATE_TEST_CASE_P(
452 MAYBE_TabindexFocusDownloads, 456 DISABLED_TabindexFocusDownloads,
453 FileManagerBrowserTestWithLegacyEventDispatch, 457 FileManagerBrowserTestWithLegacyEventDispatch,
454 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, 458 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
455 "tabindexFocusDownloads"), 459 "tabindexFocusDownloads"),
456 TestParameter(IN_GUEST_MODE, "tabindexFocusDownloads"))); 460 TestParameter(IN_GUEST_MODE, "tabindexFocusDownloads")));
457 461
458 #if defined(DISABLE_SLOW_FILESAPP_TESTS) 462 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
459 #define MAYBE_TabindexFocusDirectorySelected \ 463 #define MAYBE_TabindexFocusDirectorySelected \
460 DISABLED_TabindexFocusDirectorySelected 464 DISABLED_TabindexFocusDirectorySelected
461 #else 465 #else
462 #define MAYBE_TabindexFocusDirectorySelected TabindexFocusDirectorySelected 466 #define MAYBE_TabindexFocusDirectorySelected TabindexFocusDirectorySelected
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
533 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsUsbToDrive"), 537 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsUsbToDrive"),
534 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsDriveToLocal"), 538 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsDriveToLocal"),
535 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsDriveToUsb"), 539 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsDriveToUsb"),
536 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsUsbToLocal"))); 540 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsUsbToLocal")));
537 541
538 #if defined(DISABLE_SLOW_FILESAPP_TESTS) 542 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
539 #define MAYBE_ShowGridView DISABLED_ShowGridView 543 #define MAYBE_ShowGridView DISABLED_ShowGridView
540 #else 544 #else
541 #define MAYBE_ShowGridView ShowGridView 545 #define MAYBE_ShowGridView ShowGridView
542 #endif 546 #endif
547 // Flaky: crbug.com/698772
543 WRAPPED_INSTANTIATE_TEST_CASE_P( 548 WRAPPED_INSTANTIATE_TEST_CASE_P(
544 MAYBE_ShowGridView, 549 DISABLED_ShowGridView,
545 FileManagerBrowserTest, 550 FileManagerBrowserTest,
546 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "showGridViewDownloads"), 551 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "showGridViewDownloads"),
547 TestParameter(IN_GUEST_MODE, "showGridViewDownloads"), 552 TestParameter(IN_GUEST_MODE, "showGridViewDownloads"),
548 TestParameter(NOT_IN_GUEST_MODE, "showGridViewDrive"))); 553 TestParameter(NOT_IN_GUEST_MODE, "showGridViewDrive")));
549 554
550 #if defined(DISABLE_SLOW_FILESAPP_TESTS) 555 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
551 #define MAYBE_Providers DISABLED_Providers 556 #define MAYBE_Providers DISABLED_Providers
552 #else 557 #else
553 #define MAYBE_Providers Providers 558 #define MAYBE_Providers Providers
554 #endif 559 #endif
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
699 704
700 IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, MAYBE_BasicDrive) { 705 IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, MAYBE_BasicDrive) {
701 AddAllUsers(); 706 AddAllUsers();
702 707
703 // Sanity check that normal operations work in multi-profile setting as well. 708 // Sanity check that normal operations work in multi-profile setting as well.
704 set_test_case_name("keyboardCopyDrive"); 709 set_test_case_name("keyboardCopyDrive");
705 StartTest(); 710 StartTest();
706 } 711 }
707 712
708 } // namespace file_manager 713 } // namespace file_manager
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698