Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: remoting/client/ios/bridge/client_instance.cc

Issue 2753963002: Refactoring and rewriting the chromoting jni instance to be chromoting session. (Closed)
Patch Set: Updating based on feedback. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/ios/bridge/client_instance.h ('k') | remoting/client/jni/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/ios/bridge/client_instance.cc
diff --git a/remoting/client/ios/bridge/client_instance.cc b/remoting/client/ios/bridge/client_instance.cc
index 25e98525d5b88d52e39225176b39b5a417154b3a..17c6bb6f45306dae0158a4f1ce61b70ed366ee23 100644
--- a/remoting/client/ios/bridge/client_instance.cc
+++ b/remoting/client/ios/bridge/client_instance.cc
@@ -14,7 +14,7 @@
#include "remoting/base/chromium_url_request.h"
#include "remoting/base/url_request_context_getter.h"
#include "remoting/client/audio_player.h"
-#include "remoting/client/client_status_logger.h"
+//#include "remoting/client/client_status_logger.h"
#include "remoting/client/ios/bridge/client_proxy.h"
#include "remoting/proto/event.pb.h"
#include "remoting/protocol/chromium_port_allocator_factory.h"
@@ -33,7 +33,7 @@
namespace {
const char* const kXmppServer = "talk.google.com";
-const char kDirectoryBotJid[] = "remoting@bot.talk.google.com";
+// const char kDirectoryBotJid[] = "remoting@bot.talk.google.com";
} // namespace
namespace remoting {
@@ -191,7 +191,7 @@ void ClientInstance::OnConnectionState(protocol::ConnectionToHost::State state,
protocol::ErrorCode error) {
DCHECK(network_task_runner_->BelongsToCurrentThread());
- client_status_logger_->LogSessionStateChange(state, error);
+ // client_status_logger_->LogSessionStateChange(state, error);
ui_task_runner_->PostTask(
FROM_HERE, base::Bind(&ClientInstance::HandleConnectionStateOnUIThread,
@@ -287,8 +287,8 @@ void ClientInstance::ConnectToHostOnNetworkThread() {
new XmppSignalStrategy(net::ClientSocketFactory::GetDefaultFactory(),
url_requester_, xmpp_config_));
- client_status_logger_.reset(new ClientStatusLogger(
- ServerLogEntry::ME2ME, signaling_.get(), kDirectoryBotJid));
+ // client_status_logger_.reset(new ClientStatusLogger(
+ // ServerLogEntry::ME2ME, signaling_.get(), kDirectoryBotJid));
protocol::NetworkSettings network_settings(
protocol::NetworkSettings::NAT_TRAVERSAL_FULL);
@@ -324,7 +324,7 @@ void ClientInstance::DisconnectFromHostOnNetworkThread() {
// |client_| must be torn down before |signaling_|.
client_.reset();
- client_status_logger_.reset();
+ // client_status_logger_.reset();
signaling_.reset();
perf_tracker_.reset();
// audio_consumer_->reset(); // TODO(nicholss): Or should this be a call to
« no previous file with comments | « remoting/client/ios/bridge/client_instance.h ('k') | remoting/client/jni/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698