Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: remoting/client/chromoting_client_runtime.h

Issue 2753963002: Refactoring and rewriting the chromoting jni instance to be chromoting session. (Closed)
Patch Set: Fixed feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/chromoting_client_runtime.h
diff --git a/remoting/client/chromoting_client_runtime.h b/remoting/client/chromoting_client_runtime.h
index d3082760c6200e8934d36af9bc1ecd91cc4d0c1c..391a2c335830edd3e3c774be04e145ea87ceec92 100644
--- a/remoting/client/chromoting_client_runtime.h
+++ b/remoting/client/chromoting_client_runtime.h
@@ -70,7 +70,7 @@ class ChromotingClientRuntime {
return url_requester_;
}
- // Must call and use log_writter on the network thread.
+ // Must call and use log_writer on the network thread.
ChromotingEventLogWriter* log_writer();
private:
@@ -87,6 +87,12 @@ class ChromotingClientRuntime {
// References to native threads.
scoped_refptr<AutoThreadTaskRunner> ui_task_runner_;
+ // TODO(nicholss): AutoThreads will be leaked because they depend on the main
+ // thread. We should update this class to use regular threads like the client
+ // plugin does.
+ // Longer term we should migrate most of these to background tasks except the
+ // network thread to TaskScheduler, removing the need for threads.
+
scoped_refptr<AutoThreadTaskRunner> display_task_runner_;
scoped_refptr<AutoThreadTaskRunner> network_task_runner_;
scoped_refptr<AutoThreadTaskRunner> file_task_runner_;

Powered by Google App Engine
This is Rietveld 408576698