remoting/client/native_device_keymap.h - Issue 2753963002: Refactoring and rewriting the chromoting jni instance to be chromoting session.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/client/native_device_keymap.h

Issue 2753963002: Refactoring and rewriting the chromoting jni instance to be chromoting session. (Closed)

Patch Set: Pointer not obj. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.
	Lambros 2017/03/24 00:07:15 2017 We usually update the year when we move or re 2017 We usually update the year when we move or rename a file. nicholss 2017/03/29 20:32:36 I have only changed that when it is a new file, no Show quoted text On 2017/03/24 00:07:15, Lambros wrote: > 2017 > We usually update the year when we move or rename a file. I have only changed that when it is a new file, not a move. Looks like the style guide does not define what should happen on move: https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_CLIENT_NATIVE_DEVICE_KEYMAP_H_

	6 #define REMOTING_CLIENT_NATIVE_DEVICE_KEYMAP_H_

	7

	8 #include <stddef.h>

	9 #include <stdint.h>

	10

	11 #include <memory>
	Yuwei 2017/03/21 20:40:30 Remove this include? Remove this include? nicholss 2017/03/29 20:32:36 Done. Show quoted text On 2017/03/21 20:40:30, Yuwei wrote: > Remove this include? Done.
	12

	13 namespace remoting {

	14

	15 uint32_t NativeDeviceKeycodeToUsbKeycode(size_t device_keycode);

	16

	17 } // namespace remoting

	18

	19 #endif // REMOTING_CLIENT_NATIVE_DEVICE_KEYMAP_H_

OLD	NEW