Refactoring and rewriting the chromoting jni instance to be chromoting session.

remoting/client/chromoting_client_runtime.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_CLIENT_CHROMOTING_CLIENT_RUNTIME_H_
 #define REMOTING_CLIENT_CHROMOTING_CLIENT_RUNTIME_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 52 matching lines @@
   }
 
   scoped_refptr<AutoThreadTaskRunner> file_task_runner() {
     return file_task_runner_;
   }
 
   scoped_refptr<net::URLRequestContextGetter> url_requester() {
     return url_requester_;
   }
 
-  // Must call and use log_writter on the network thread.
+  // Must call and use log_writer on the network thread.
   ChromotingEventLogWriter* log_writer();
 
  private:
   ChromotingClientRuntime();
   virtual ~ChromotingClientRuntime();
 
   void CreateLogWriter();
   void RequestAuthTokenForLogger();
 
   // Chromium code's connection to the app message loop. Once created the
   // MessageLoop will live for the life of the program.
   std::unique_ptr<base::MessageLoopForUI> ui_loop_;
 
   // References to native threads.
   scoped_refptr<AutoThreadTaskRunner> ui_task_runner_;
 
+  // TODO(nicholss): Auththreads will be leaked because they depend on the main

[Lambros, 2017/03/24 00:07:14]

s/Auththreads/AutoThreads ?

[nicholss, 2017/03/29 20:32:35]

Done.

+  // thread. We should update this class to use regular threads like the client
+  // plugin does.
+  // Longer term we should migrate most of these to background tasks execpt the

[Lambros, 2017/03/24 00:07:14]

except

[nicholss, 2017/03/29 20:32:35]

Done.

+  // network thread to TaskSchedular, removing the need for threads.

[Lambros, 2017/03/24 00:07:14]

TaskScheduler

[nicholss, 2017/03/29 20:32:35]

Done. This was copied from a comment given to me via another code review, I did
not proof it enough I guess. :)

+
   scoped_refptr<AutoThreadTaskRunner> display_task_runner_;
   scoped_refptr<AutoThreadTaskRunner> network_task_runner_;
   scoped_refptr<AutoThreadTaskRunner> file_task_runner_;
 
   scoped_refptr<net::URLRequestContextGetter> url_requester_;
 
   // For logging session stage changes and stats.
   std::unique_ptr<TelemetryLogWriter> log_writer_;
 
   ChromotingClientRuntime::Delegate* delegate_;
 
   friend struct base::DefaultSingletonTraits<ChromotingClientRuntime>;
 
   DISALLOW_COPY_AND_ASSIGN(ChromotingClientRuntime);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_CLIENT_CHROMOTING_CLIENT_RUNTIME_H_