Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4641)

Unified Diff: cc/trees/layer_tree_impl.cc

Issue 2753933005: cc: Move Layer Id to Node Map to Individual Property Tree Private (Closed)
Patch Set: add virtual to desctructor of ptree Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_impl.cc
diff --git a/cc/trees/layer_tree_impl.cc b/cc/trees/layer_tree_impl.cc
index 3f72103469824fee4c51f7a632225f7a32231b76..578fcb3d13b886d29ab2359869d923c85de54e7b 100644
--- a/cc/trees/layer_tree_impl.cc
+++ b/cc/trees/layer_tree_impl.cc
@@ -724,9 +724,7 @@ void LayerTreeImpl::UpdatePropertyTreeScrollingAndAnimationFromMainThread() {
std::vector<int> layer_ids_to_remove;
for (auto& layer_id_to_opacity : opacity_animations_map_) {
const int id = layer_id_to_opacity.first;
- if (property_trees_.IsInIdToIndexMap(PropertyTrees::TreeType::EFFECT, id)) {
- EffectNode* node = property_trees_.effect_tree.Node(
- property_trees_.layer_id_to_effect_node_index[id]);
+ if (EffectNode* node = property_trees_.effect_tree.FindNodeFromId(id)) {
if (!node->is_currently_animating_opacity ||
node->opacity == layer_id_to_opacity.second) {
layer_ids_to_remove.push_back(id);
@@ -742,10 +740,8 @@ void LayerTreeImpl::UpdatePropertyTreeScrollingAndAnimationFromMainThread() {
for (auto& layer_id_to_transform : transform_animations_map_) {
const int id = layer_id_to_transform.first;
- if (property_trees_.IsInIdToIndexMap(PropertyTrees::TreeType::TRANSFORM,
- id)) {
- TransformNode* node = property_trees_.transform_tree.Node(
- property_trees_.layer_id_to_transform_node_index[id]);
+ if (TransformNode* node =
+ property_trees_.transform_tree.FindNodeFromId(id)) {
if (!node->is_currently_animating ||
node->local == layer_id_to_transform.second) {
layer_ids_to_remove.push_back(id);
@@ -762,9 +758,7 @@ void LayerTreeImpl::UpdatePropertyTreeScrollingAndAnimationFromMainThread() {
for (auto& layer_id_to_filters : filter_animations_map_) {
const int id = layer_id_to_filters.first;
- if (property_trees_.IsInIdToIndexMap(PropertyTrees::TreeType::EFFECT, id)) {
- EffectNode* node = property_trees_.effect_tree.Node(
- property_trees_.layer_id_to_effect_node_index[id]);
+ if (EffectNode* node = property_trees_.effect_tree.FindNodeFromId(id)) {
if (!node->is_currently_animating_filter ||
node->filters == layer_id_to_filters.second) {
layer_ids_to_remove.push_back(id);

Powered by Google App Engine
This is Rietveld 408576698