Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2753923003: Format all analyzer packages

Created:
3 years, 9 months ago by Jacob
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Format all analyzer packages BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : Format all analyzer packages #

Patch Set 3 : Format all analyzer packages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8268 lines, -2901 lines) Patch
M pkg/analysis_server/benchmark/integration/input_converter.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/benchmark/integration/local_runner.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analysis_server/benchmark/integration/operation.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/protocol.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_execution.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.g.dart View 1 1 chunk +3859 lines, -411 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/abstract_single_unit.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_options_test.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/organize_directives_test.dart View 1 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/execution/map_uri_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/search/find_top_level_declarations_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/search/test_all.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/abstract_search_domain.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 1 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/tool/spec/generate_files View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/codegen/html.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/error/hint_codes.dart View 1 11 chunks +24 lines, -26 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/sdk/patch.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/workspace.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/fasta/model.dart View 1 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 1 325 chunks +2490 lines, -1338 lines 0 comments Download
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/inputs.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/analysis_context_factory.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/html_work_manager_test.dart View 1 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/analyzer_cli/test/data/bazel/proj/lib/file.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/test/data/flutter_analysis_options/lib/main.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/test/data/flutter_analysis_options/somepkgs/flutter/lib/material.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/test/data/options_include_directive_tests_project/lib/test_file.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analyzer_cli/test/data/options_tests_project/test_file.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer_cli/test/data/package_with_embedder_yaml/lib/core.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_constants.dart View 1 3 chunks +12 lines, -6 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart View 1 253 chunks +1428 lines, -602 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart View 1 9 chunks +49 lines, -23 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart View 1 72 chunks +317 lines, -432 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Jacob
Please add other reviewers if needed https://codereview.chromium.org/2753923003/diff/1/pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart File pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart (left): https://codereview.chromium.org/2753923003/diff/1/pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart#oldcode21 pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart:21: @override I'd suggest ...
3 years, 9 months ago (2017-03-16 03:44:55 UTC) #2
Brian Wilkerson
3 years, 9 months ago (2017-03-16 13:50:55 UTC) #3 
You can't commit the changes to generated files. We have a test that ensures
that the content of these files is exactly what the generator produces so that
we can't forget to run the generator. Hence, these changes will cause a test
failure.

Other than that, lgtm.

Powered by Google App Engine
This is Rietveld 408576698