Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1807)

Unified Diff: cc/scheduler/scheduler.cc

Issue 2753843003: Create a new action triggered when a BeginMainFrame is not expected before vsync (Closed)
Patch Set: tweak scheduler to not schedule idle work after a commit. Complete renaming. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/scheduler.cc
diff --git a/cc/scheduler/scheduler.cc b/cc/scheduler/scheduler.cc
index d532ce3b07d7478d7eea238f0df43884f7d299e5..0f0e43d0a8d7e82d8b2acaeced57d26a76924db0 100644
--- a/cc/scheduler/scheduler.cc
+++ b/cc/scheduler/scheduler.cc
@@ -215,6 +215,13 @@ base::TimeTicks Scheduler::LastBeginImplFrameTime() {
return begin_impl_frame_tracker_.Current().frame_time;
}
+void Scheduler::BeginMainFrameNotExpectedUntil(base::TimeTicks time) {
+ // TODO(delphick): Do we need to log this?
Sami 2017/04/06 17:39:09 Let's add: TRACE_EVENT0("cc", "Scheduler::BeginMa
Dan Elphick 2017/04/07 09:05:02 Done.
+ compositor_timing_history_->BeginImplFrameNotExpectedSoon();
+
+ client_->ScheduledActionBeginMainFrameNotExpectedUntil(time);
+}
+
void Scheduler::BeginImplFrameNotExpectedSoon() {
compositor_timing_history_->BeginImplFrameNotExpectedSoon();
@@ -629,6 +636,11 @@ void Scheduler::ProcessScheduledActions() {
// TODO(brianderson): Pass begin_main_frame_args_ directly to client.
client_->ScheduledActionSendBeginMainFrame(begin_main_frame_args_);
break;
+ case SchedulerStateMachine::ACTION_NOTIFY_BEGIN_MAIN_FRAME_NOT_SENT:
+ state_machine_.WillNotifyBeginMainFrameNotSent();
+ BeginMainFrameNotExpectedUntil(begin_main_frame_args_.frame_time +
+ begin_main_frame_args_.interval);
+ break;
case SchedulerStateMachine::ACTION_COMMIT: {
bool commit_has_no_updates = false;
state_machine_.WillCommit(commit_has_no_updates);

Powered by Google App Engine
This is Rietveld 408576698