Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 275383003: Renamed Tryjob label to Tryjob-Request (Closed)

Created:
6 years, 7 months ago by nodir
Modified:
6 years, 7 months ago
Reviewers:
kmg, Vadim Sh., Kevin Graney
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Renamed Tryjob label to Tryjob-Request Some users interpreted Tryjob=+1 as "passed a try job", so renaming this one Assuming will never rename again. TBR=vadimsh@chromium.org BUG=369665 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270011

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M trychange.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nodir
6 years, 7 months ago (2014-05-11 06:47:31 UTC) #1
Kevin Graney
On 2014/05/11 06:47:31, nodir wrote: LGTM
6 years, 7 months ago (2014-05-12 11:38:13 UTC) #2
nodir
On 2014/05/12 11:38:13, Kevin Graney wrote: > On 2014/05/11 06:47:31, nodir wrote: > > LGTM ...
6 years, 7 months ago (2014-05-12 17:10:37 UTC) #3
Kevin Graney
On 2014/05/12 17:10:37, nodir wrote: > On 2014/05/12 11:38:13, Kevin Graney wrote: > > On ...
6 years, 7 months ago (2014-05-12 17:15:08 UTC) #4
nodir
Committed patchset #1 manually as r270011.
6 years, 7 months ago (2014-05-13 04:15:31 UTC) #5
nodir
On 2014/05/13 04:15:31, nodir wrote: > Committed patchset #1 manually as r270011. TBRed (kmg is ...
6 years, 7 months ago (2014-05-13 04:17:23 UTC) #6
Vadim Sh.
6 years, 7 months ago (2014-05-13 17:54:00 UTC) #7
Message was sent while issue was closed.
I'm not an OWNER in depot_tool either. But lgtm anyway, it is a trivial change.

Powered by Google App Engine
This is Rietveld 408576698