Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 275383002: Use ExtensionRegistryObserver instead of deprecated extension notification from c/b/e/api. (Closed)

Created:
6 years, 7 months ago by limasdf
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use ExtensionRegistryObserver instead of deprecated extension notification from c/b/e/api. This clean up alarm, declarative, idle, push_messaing API. R=kalman@chromium.org BUG=354046, 354458 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270024

Patch Set 1 : #

Total comments: 6

Patch Set 2 : address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -153 lines) Patch
M chrome/browser/extensions/api/alarms/alarm_manager.h View 1 5 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/alarms/alarm_manager.cc View 5 chunks +27 lines, -36 lines 0 comments Download
M chrome/browser/extensions/api/alarms/alarms_api.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.h View 5 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.cc View 1 4 chunks +16 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_api_unittest.cc View 3 chunks +10 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager.h View 5 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager.cc View 3 chunks +8 lines, -17 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.h View 1 6 chunks +20 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 1 4 chunks +47 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
limasdf
ptal
6 years, 7 months ago (2014-05-11 12:30:20 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/275383002/diff/80001/chrome/browser/extensions/api/alarms/alarm_manager.h File chrome/browser/extensions/api/alarms/alarm_manager.h (right): https://codereview.chromium.org/275383002/diff/80001/chrome/browser/extensions/api/alarms/alarm_manager.h#newcode34 chrome/browser/extensions/api/alarms/alarm_manager.h:34: class ExtensionAlarmsSchedulingTest; alphabetic https://codereview.chromium.org/275383002/diff/80001/chrome/browser/extensions/api/declarative/rules_registry_service.cc File chrome/browser/extensions/api/declarative/rules_registry_service.cc (right): https://codereview.chromium.org/275383002/diff/80001/chrome/browser/extensions/api/declarative/rules_registry_service.cc#newcode210 chrome/browser/extensions/api/declarative/rules_registry_service.cc:210: ...
6 years, 7 months ago (2014-05-12 17:53:27 UTC) #2
limasdf
ptal https://codereview.chromium.org/275383002/diff/80001/chrome/browser/extensions/api/alarms/alarm_manager.h File chrome/browser/extensions/api/alarms/alarm_manager.h (right): https://codereview.chromium.org/275383002/diff/80001/chrome/browser/extensions/api/alarms/alarm_manager.h#newcode34 chrome/browser/extensions/api/alarms/alarm_manager.h:34: class ExtensionAlarmsSchedulingTest; On 2014/05/12 17:53:27, kalman wrote: > ...
6 years, 7 months ago (2014-05-12 23:19:49 UTC) #3
limasdf
https://codereview.chromium.org/275383002/diff/80001/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc File chrome/browser/extensions/api/push_messaging/push_messaging_api.cc (right): https://codereview.chromium.org/275383002/diff/80001/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc#newcode332 chrome/browser/extensions/api/push_messaging/push_messaging_api.cc:332: } On 2014/05/12 17:53:27, kalman wrote: > can you ...
6 years, 7 months ago (2014-05-12 23:20:15 UTC) #4
not at google - send to devlin
lgtm
6 years, 7 months ago (2014-05-13 00:04:08 UTC) #5
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-05-13 00:07:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/275383002/100001
6 years, 7 months ago (2014-05-13 00:08:09 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 05:09:49 UTC) #8
Message was sent while issue was closed. 
Change committed as 270024

Powered by Google App Engine
This is Rietveld 408576698