Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/interface-descriptors.h

Issue 2753793002: [builtins] Separate Array.prototype.* CSA builtins into two parts (Closed)
Patch Set: Remove stray changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/code-assembler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interface-descriptors.h
diff --git a/src/interface-descriptors.h b/src/interface-descriptors.h
index c31838661f1e9ec06a19965550c301c5bd03c6d3..016ae62d24c04feb0b25660f8248367d27866936 100644
--- a/src/interface-descriptors.h
+++ b/src/interface-descriptors.h
@@ -16,86 +16,87 @@ namespace internal {
class PlatformInterfaceDescriptor;
-#define INTERFACE_DESCRIPTOR_LIST(V) \
- V(Void) \
- V(ContextOnly) \
- V(Load) \
- V(LoadWithVector) \
- V(LoadField) \
- V(LoadICProtoArray) \
- V(LoadGlobal) \
- V(LoadGlobalWithVector) \
- V(Store) \
- V(StoreWithVector) \
- V(StoreNamedTransition) \
- V(StoreTransition) \
- V(VarArgFunction) \
- V(FastNewClosure) \
- V(FastNewFunctionContext) \
- V(FastNewObject) \
- V(FastNewArguments) \
- V(TypeConversion) \
- V(Typeof) \
- V(FastCloneRegExp) \
- V(FastCloneShallowArray) \
- V(FastCloneShallowObject) \
- V(CreateAllocationSite) \
- V(CreateWeakCell) \
- V(CallFunction) \
- V(CallIC) \
- V(CallICTrampoline) \
- V(CallForwardVarargs) \
- V(CallConstruct) \
- V(CallTrampoline) \
- V(ConstructStub) \
- V(ConstructTrampoline) \
- V(RegExpExec) \
- V(RegExpReplace) \
- V(RegExpSplit) \
- V(CopyFastSmiOrObjectElements) \
- V(TransitionElementsKind) \
- V(AllocateHeapNumber) \
- V(Builtin) \
- V(ArrayConstructor) \
- V(ForEach) \
- V(ArrayNoArgumentConstructor) \
- V(ArraySingleArgumentConstructor) \
- V(ArrayNArgumentsConstructor) \
- V(Compare) \
- V(BinaryOp) \
- V(BinaryOpWithAllocationSite) \
- V(BinaryOpWithVector) \
- V(CountOp) \
- V(StringAdd) \
- V(StringCharAt) \
- V(StringCharCodeAt) \
- V(StringCompare) \
- V(StringIndexOf) \
- V(SubString) \
- V(Keyed) \
- V(Named) \
- V(CreateIterResultObject) \
- V(HasProperty) \
- V(ForInFilter) \
- V(ForInNext) \
- V(ForInPrepare) \
- V(GetProperty) \
- V(CallHandler) \
- V(ArgumentAdaptor) \
- V(ApiCallback) \
- V(ApiGetter) \
- V(MathPowTagged) \
- V(MathPowInteger) \
- V(GrowArrayElements) \
- V(NewArgumentsElements) \
- V(InterpreterDispatch) \
- V(InterpreterPushArgsAndCall) \
- V(InterpreterPushArgsAndConstruct) \
- V(InterpreterPushArgsAndConstructArray) \
- V(InterpreterCEntry) \
- V(ResumeGenerator) \
- V(FrameDropperTrampoline) \
- V(PromiseHandleReject) \
+#define INTERFACE_DESCRIPTOR_LIST(V) \
+ V(Void) \
+ V(ContextOnly) \
+ V(Load) \
+ V(LoadWithVector) \
+ V(LoadField) \
+ V(LoadICProtoArray) \
+ V(LoadGlobal) \
+ V(LoadGlobalWithVector) \
+ V(Store) \
+ V(StoreWithVector) \
+ V(StoreNamedTransition) \
+ V(StoreTransition) \
+ V(VarArgFunction) \
+ V(FastNewClosure) \
+ V(FastNewFunctionContext) \
+ V(FastNewObject) \
+ V(FastNewArguments) \
+ V(TypeConversion) \
+ V(Typeof) \
+ V(FastCloneRegExp) \
+ V(FastCloneShallowArray) \
+ V(FastCloneShallowObject) \
+ V(CreateAllocationSite) \
+ V(CreateWeakCell) \
+ V(CallFunction) \
+ V(CallIC) \
+ V(CallICTrampoline) \
+ V(CallForwardVarargs) \
+ V(CallConstruct) \
+ V(CallTrampoline) \
+ V(ConstructStub) \
+ V(ConstructTrampoline) \
+ V(RegExpExec) \
+ V(RegExpReplace) \
+ V(RegExpSplit) \
+ V(CopyFastSmiOrObjectElements) \
+ V(TransitionElementsKind) \
+ V(AllocateHeapNumber) \
+ V(Builtin) \
+ V(ArrayConstructor) \
+ V(IteratingArrayBuiltin) \
+ V(IteratingArrayBuiltinLoopContinuation) \
+ V(ArrayNoArgumentConstructor) \
+ V(ArraySingleArgumentConstructor) \
+ V(ArrayNArgumentsConstructor) \
+ V(Compare) \
+ V(BinaryOp) \
+ V(BinaryOpWithAllocationSite) \
+ V(BinaryOpWithVector) \
+ V(CountOp) \
+ V(StringAdd) \
+ V(StringCharAt) \
+ V(StringCharCodeAt) \
+ V(StringCompare) \
+ V(StringIndexOf) \
+ V(SubString) \
+ V(Keyed) \
+ V(Named) \
+ V(CreateIterResultObject) \
+ V(HasProperty) \
+ V(ForInFilter) \
+ V(ForInNext) \
+ V(ForInPrepare) \
+ V(GetProperty) \
+ V(CallHandler) \
+ V(ArgumentAdaptor) \
+ V(ApiCallback) \
+ V(ApiGetter) \
+ V(MathPowTagged) \
+ V(MathPowInteger) \
+ V(GrowArrayElements) \
+ V(NewArgumentsElements) \
+ V(InterpreterDispatch) \
+ V(InterpreterPushArgsAndCall) \
+ V(InterpreterPushArgsAndConstruct) \
+ V(InterpreterPushArgsAndConstructArray) \
+ V(InterpreterCEntry) \
+ V(ResumeGenerator) \
+ V(FrameDropperTrampoline) \
+ V(PromiseHandleReject) \
V(WasmRuntimeCall)
class V8_EXPORT_PRIVATE CallInterfaceDescriptorData {
@@ -286,39 +287,38 @@ class V8_EXPORT_PRIVATE CallInterfaceDescriptor {
kContext = kParameterCount /* implicit parameter */ \
};
-#define DECLARE_BUILTIN_DESCRIPTOR(name) \
- DECLARE_DESCRIPTOR_WITH_BASE(name, BuiltinDescriptor) \
- protected: \
- void InitializePlatformIndependent(CallInterfaceDescriptorData* data) \
- override { \
- MachineType machine_types[] = {MachineType::AnyTagged(), \
- MachineType::AnyTagged(), \
- MachineType::Int32()}; \
- int argc = kStackParameterCount + 1 - arraysize(machine_types); \
- data->InitializePlatformIndependent(arraysize(machine_types), argc, \
- machine_types); \
- } \
- void InitializePlatformSpecific(CallInterfaceDescriptorData* data) \
- override { \
- Register registers[] = {TargetRegister(), NewTargetRegister(), \
- ArgumentsCountRegister()}; \
- data->InitializePlatformSpecific(arraysize(registers), registers); \
- } \
- \
- public:
-
-#define DEFINE_BUILTIN_PARAMETERS(...) \
- enum ParameterIndices { \
- kReceiver, \
- kBeforeFirstStackParameter = kReceiver, \
- __VA_ARGS__, \
- kAfterLastStackParameter, \
- kNewTarget = kAfterLastStackParameter, \
- kArgumentsCount, \
- kContext, /* implicit parameter */ \
- kParameterCount = kContext, \
- kStackParameterCount = \
- kAfterLastStackParameter - kBeforeFirstStackParameter - 1, \
+#define DECLARE_BUILTIN_DESCRIPTOR(name) \
+ DECLARE_DESCRIPTOR_WITH_BASE(name, BuiltinDescriptor) \
+ protected: \
+ void InitializePlatformIndependent(CallInterfaceDescriptorData* data) \
+ override { \
+ MachineType machine_types[] = {MachineType::AnyTagged(), \
+ MachineType::AnyTagged(), \
+ MachineType::Int32()}; \
+ data->InitializePlatformIndependent(arraysize(machine_types), \
+ kStackParameterCount, machine_types); \
+ } \
+ void InitializePlatformSpecific(CallInterfaceDescriptorData* data) \
+ override { \
+ Register registers[] = {TargetRegister(), NewTargetRegister(), \
+ ArgumentsCountRegister()}; \
+ data->InitializePlatformSpecific(arraysize(registers), registers); \
+ } \
+ \
+ public:
+
+#define DEFINE_BUILTIN_PARAMETERS(...) \
+ enum ParameterIndices { \
+ kReceiver, \
+ kBeforeFirstStackParameter = kReceiver, \
+ __VA_ARGS__, \
+ kAfterLastStackParameter, \
+ kNewTarget = kAfterLastStackParameter, \
+ kArgumentsCount, \
+ kContext, /* implicit parameter */ \
+ kParameterCount = kContext, \
+ kArity = kAfterLastStackParameter - kBeforeFirstStackParameter - 1, \
+ kStackParameterCount = kArity + 1 \
};
class VoidDescriptor : public CallInterfaceDescriptor {
@@ -702,10 +702,18 @@ class BuiltinDescriptor : public CallInterfaceDescriptor {
static const Register TargetRegister();
};
-class ForEachDescriptor : public BuiltinDescriptor {
+class IteratingArrayBuiltinDescriptor : public BuiltinDescriptor {
public:
DEFINE_BUILTIN_PARAMETERS(kCallback, kThisArg)
- DECLARE_BUILTIN_DESCRIPTOR(ForEachDescriptor)
+ DECLARE_BUILTIN_DESCRIPTOR(IteratingArrayBuiltinDescriptor)
+};
+
+class IteratingArrayBuiltinLoopContinuationDescriptor
+ : public BuiltinDescriptor {
+ public:
+ DEFINE_BUILTIN_PARAMETERS(kCallback, kThisArg, kArray, kObject, kInitialK,
+ kLength)
+ DECLARE_BUILTIN_DESCRIPTOR(IteratingArrayBuiltinLoopContinuationDescriptor)
};
class ArrayConstructorDescriptor : public CallInterfaceDescriptor {
« no previous file with comments | « src/compiler/code-assembler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698