Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/svg/SVGViewSpec.h

Issue 2753773009: Inherit 'viewBox' into view spec if it is valid (Closed)
Patch Set: Tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/as-image/view-with-preserveaspectratio-only-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGViewSpec.h
diff --git a/third_party/WebKit/Source/core/svg/SVGViewSpec.h b/third_party/WebKit/Source/core/svg/SVGViewSpec.h
index 3d7ea0384d9da25c484baab9372a34e9b057cf17..ac8fe5c3722b0006c1c7a3d2c9d28f6d946d1434 100644
--- a/third_party/WebKit/Source/core/svg/SVGViewSpec.h
+++ b/third_party/WebKit/Source/core/svg/SVGViewSpec.h
@@ -65,7 +65,7 @@ class SVGViewSpec final : public GarbageCollectedFinalized<SVGViewSpec>,
template <typename T>
void SVGViewSpec::inheritViewAttributesFromElement(T& inheritFromElement) {
- if (!inheritFromElement.hasEmptyViewBox())
+ if (inheritFromElement.viewBox()->currentValue()->isValid())
setViewBox(inheritFromElement.viewBox()->currentValue()->value());
if (inheritFromElement.preserveAspectRatio()->isSpecified()) {
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/as-image/view-with-preserveaspectratio-only-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698