Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2753773003: v8bindings: Reverts crrev.com/2606723002 with minimum changes. (Closed)
Patch Set: Updated tests and their expectations. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/xss-DENIED-window-name-alert-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
index 915102948d8251d2f6a80673b9c5daf47e590ea2..283c590be9c5312296756203310d1f3c475874be 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
@@ -354,6 +354,14 @@ void V8Window::namedPropertyGetterCustom(
v8SetReturnValueFast(info, child->domWindow(), window);
return;
}
+
+ // In addition to the above spec'ed case, we return the child window
+ // regardless of step 3 due to crbug.com/701489 for the time being.
+ // TODO(yukishiino): Makes iframe.name update the browsing context name
+ // appropriately and makes the new name available in the named access on
+ // window. Then, removes the following two lines.
+ v8SetReturnValueFast(info, child->domWindow(), window);
+ return;
}
// This is a cross-origin interceptor. Check that the caller has access to the
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/xss-DENIED-window-name-alert-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698