Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 2753773003: v8bindings: Reverts crrev.com/2606723002 with minimum changes. (Closed)
Patch Set: Updated tests and their expectations. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/external/wpt/html/browsers/the-window-object/window-named-properties-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/site_per_process_browsertest.cc
diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc
index 2dcae41818e9614ca9c2d5badce9478bd45e8257..0ce174b4b389a7a48d5e193a2897a80d886cb570 100644
--- a/content/browser/site_per_process_browsertest.cc
+++ b/content/browser/site_per_process_browsertest.cc
@@ -4023,7 +4023,10 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, DynamicWindowName) {
"window.domAutomationController.send("
" frames['updated-name'] === undefined);",
&success));
- EXPECT_TRUE(success);
+ // TODO(yukishiino): The following expectation should be TRUE, but we're
+ // intentionally disabling the name and origin check of the named access on
+ // window. See also crbug.com/538562 and crbug.com/701489.
+ EXPECT_FALSE(success);
// Change iframe's name to match the content window's name so that it can
// reference the child frame by its new name in case of cross origin.
EXPECT_TRUE(
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/external/wpt/html/browsers/the-window-object/window-named-properties-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698