Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4477)

Unified Diff: chrome/test/chromedriver/performance_logger.cc

Issue 2753763005: [chromedriver] Use percentFull instead of value in Tracing.bufferUsage. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/chromedriver/performance_logger_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/performance_logger.cc
diff --git a/chrome/test/chromedriver/performance_logger.cc b/chrome/test/chromedriver/performance_logger.cc
index 5887650e1ae74b801fceddb62a3ac224e9fa09db..d7f61c545c3f325dee386e258b458a94b61a6b16 100644
--- a/chrome/test/chromedriver/performance_logger.cc
+++ b/chrome/test/chromedriver/performance_logger.cc
@@ -199,7 +199,7 @@ Status PerformanceLogger::HandleTraceEvents(
// 'value' will be between 0-1 and represents how full the DevTools trace
// buffer is. If the buffer is full, warn the user.
double buffer_usage = 0;
- if (!params.GetDouble("value", &buffer_usage)) {
+ if (!params.GetDouble("percentFull", &buffer_usage)) {
// Tracing.bufferUsage event will occur once per second, and it really
// only serves as a warning, so if we can't reliably tell whether the
// buffer is full, just fail silently instead of spamming the logs.
« no previous file with comments | « no previous file | chrome/test/chromedriver/performance_logger_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698