Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: components/sync_sessions/sessions_sync_manager.cc

Issue 2753753005: [sync] WebContentsObserver based sessions notifications (Closed)
Patch Set: use base:MakeUnique, alphabetize Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_sessions/sessions_sync_manager.cc
diff --git a/components/sync_sessions/sessions_sync_manager.cc b/components/sync_sessions/sessions_sync_manager.cc
index d61d75591b9a75f8bf94956cfdbe0bec00c1797b..0fba2e8a7cb899f5632a36e47a00d917613cf679 100644
--- a/components/sync_sessions/sessions_sync_manager.cc
+++ b/components/sync_sessions/sessions_sync_manager.cc
@@ -106,7 +106,7 @@ void AppendDeletionsForTabNodes(const std::set<int>& tab_node_ids,
// Ensure that the tab id is not invalid.
bool ShouldSyncTabId(SessionID::id_type tab_id) {
- if (tab_id == TabNodePool::kInvalidTabID)
+ if (tab_id == kInvalidTabID)
return false;
return true;
}
@@ -119,7 +119,7 @@ SessionsSyncManager::SessionsSyncManager(
sync_sessions::SyncSessionsClient* sessions_client,
syncer::SyncPrefs* sync_prefs,
LocalDeviceInfoProvider* local_device,
- std::unique_ptr<LocalSessionEventRouter> router,
+ LocalSessionEventRouter* router,
const base::Closure& sessions_updated_callback,
const base::Closure& datatype_refresh_callback)
: sessions_client_(sessions_client),
@@ -681,7 +681,7 @@ bool SessionsSyncManager::InitFromSyncModel(
syncer::SyncChange tombstone(TombstoneTab(specifics));
if (tombstone.IsValid())
new_changes->push_back(tombstone);
- } else if (specifics.tab().tab_id() == TabNodePool::kInvalidTabID) {
+ } else if (specifics.tab().tab_id() == kInvalidTabID) {
LOG(WARNING) << "Found tab node with invalid tab id.";
syncer::SyncChange tombstone(TombstoneTab(specifics));
if (tombstone.IsValid())
« no previous file with comments | « components/sync_sessions/sessions_sync_manager.h ('k') | components/sync_sessions/sessions_sync_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698