[sync] WebContentsObserver based sessions notifications

chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc

Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
index b89a513b7f458ebcad4c3f6391d0a6615fdab490..76da052de1b4c0db5ecff60d9aedd5ae21b1d112 100644
--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
@@ -130,11 +130,10 @@ class RecentTabsSubMenuModelTest
             sync_pb::SyncEnums_DeviceType_TYPE_LINUX,
             "device_id")) {
     sync_prefs_.reset(new syncer::SyncPrefs(testing_profile_.GetPrefs()));
+    dummy_router_.reset(new DummyRouter());

[Peter Kasting, 2017/03/22 21:52:15]

Nit: Prefer MakeUnique over bare new:

  dummy_router_ = base::MakeUnique<DummyRouter>();

Optional:

* Fix other places here
* Do some/all of these in the initializer list or in the declaration points,
instead of in code here

[Patrick Noland, 2017/03/23 20:15:03]

Done.

     manager_.reset(new sync_sessions::SessionsSyncManager(
         sync_service_.GetSyncClient()->GetSyncSessionsClient(),
-        sync_prefs_.get(), local_device_.get(),
-        std::unique_ptr<sync_sessions::LocalSessionEventRouter>(
-            new DummyRouter()),
+        sync_prefs_.get(), local_device_.get(), dummy_router_.get(),
         base::Closure(), base::Closure()));
     manager_->MergeDataAndStartSyncing(
         syncer::SESSIONS, syncer::SyncDataList(),
@@ -170,6 +169,7 @@ class RecentTabsSubMenuModelTest
   std::unique_ptr<syncer::SyncPrefs> sync_prefs_;
   std::unique_ptr<sync_sessions::SessionsSyncManager> manager_;
   std::unique_ptr<syncer::LocalDeviceInfoProviderMock> local_device_;
+  std::unique_ptr<DummyRouter> dummy_router_;
 };
 
 // Test disabled "Recently closed" header with no foreign tabs.