[sync] WebContentsObserver based sessions notifications

chrome/browser/sync/test/integration/sessions_helper.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_SESSIONS_HELPER_H_
 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_SESSIONS_HELPER_H_
 
 #include <algorithm>
 #include <map>
 #include <memory>
@@ skipping 69 matching lines @@
 // session model associator is aware of it. Returns true upon success, false
 // otherwise.
 bool OpenTab(int index, const GURL& url);
 
 // See OpenTab, except that the tab is opened in position |tab_index|.
 // If |tab_index| is -1 or greater than the number of tabs, the tab will be
 // appended to the end of the strip. i.e. if tab_index is 3 for a tab strip of
 // size 1, the new tab will be in position 1.
 bool OpenTabAtIndex(int index, int tab_index, const GURL& url);
 
+// Opens |url| from the WebContents at |index_of_source_tab| using
+// |disposition|.
+bool OpenTabFromSourceIndex(int index,
+                            int index_of_source_tab,
+                            const GURL& url,
+                            WindowOpenDisposition disposition);
+
+// Open multiple tabs and block until the session model associator is aware
+// of all of them.  Returns true on success, false on failure.
+bool OpenMultipleTabs(int index, const std::vector<GURL>& urls);
+
 // Moves the tab in position |tab_index| in the TabStrip for browser at
 // |from_index| to the TabStrip for browser at |to_index|.
 void MoveTab(int from_index, int to_index, int tab_index);
 
 // Navigate the active tab for browser in position |index| to the given
 // url, and blocks until the session model associator is aware of it.
 // WARNING: it's dangerous to assume this will return for any arbitrary URL.
 // For URLs that don't resolve to a valid server response, this can block
 // indefinitely. Use a data uri or the embedded_test_server to ensure that this
 // doesn't happen.
 bool NavigateTab(int index, const GURL& url);
 
 // Navigate the active tab for browser in position |index| back by one;
 // if this isn't possible, does nothing
 void NavigateTabBack(int index);
 
 // Navigate the active tab for browser in position |index| forward by
 // one; if this isn't possible, does nothing
 void NavigateTabForward(int index);
 
-// Open multiple tabs and block until the session model associator is aware
-// of all of them.  Returns true on success, false on failure.
-bool OpenMultipleTabs(int index, const std::vector<GURL>& urls);
+// Wait for a session change to propagate to the model associator. Will return

[Nicolas Zea, 2017/03/16 19:57:44]

nit: s/model associator/syncableservice, here and elsewhere. There is no model
associator anymore.

[Patrick Noland, 2017/03/17 00:20:10]

Done.

+// true once |url| has been found, or false if it times out while waiting.
+bool WaitForTabToLoad(int index,
+                      const GURL& url,
+                      content::WebContents* WebContents);
 
-// Wait for a session change to propagate to the model associator.  Will not
-// return until each url in |urls| has been found.
+// Wait for each url in |urls| to load. The ordering of |urls| is assumed to
+// match the ordering of the corresponding tabs.
 bool WaitForTabsToLoad(int index, const std::vector<GURL>& urls);
 
 // Check if the session model associator's knows that the current open tab
 // has this url.
 bool ModelAssociatorHasTabWithUrl(int index, const GURL& url);
 
 // Stores a pointer to the local session for a given profile in |session|.
 // Returns true on success, false on failure.
 bool GetLocalSession(int index, const sync_sessions::SyncedSession** session);
 
@@ skipping 16 matching lines @@
   // StatusChangeChecker implementation.
   bool IsExitConditionSatisfied() override;
   std::string GetDebugMessage() const override;
 
  private:
   int index_;
   const std::vector<sessions_helper::ScopedWindowMap>& windows_;
 };
 
 #endif  // CHROME_BROWSER_SYNC_TEST_INTEGRATION_SESSIONS_HELPER_H_