Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

Issue 2753743003: Make NGFragmentBuilder to keep track on text children. (Closed)
Patch Set: get a raw ptr of NGPhysicalFragment instead of RefPtr Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_line_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h
index f37b180b75c9e38aa1340290121550e48128315e..0ea09b880e0c96ab6022f2cc3d728f354aa9e994 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h
@@ -7,6 +7,7 @@
#include "core/CoreExport.h"
#include "core/layout/ng/geometry/ng_logical_offset.h"
+#include "core/layout/ng/ng_fragment_builder.h"
#include "core/layout/ng/ng_layout_opportunity_iterator.h"
#include "core/layout/ng/ng_physical_fragment.h"
#include "platform/fonts/FontBaseline.h"
@@ -18,7 +19,6 @@ namespace blink {
class ComputedStyle;
class FontMetrics;
class NGConstraintSpace;
-class NGFragmentBuilder;
class NGInlineNode;
class NGLayoutInlineItem;
@@ -143,8 +143,6 @@ class CORE_EXPORT NGLineBuilder final {
Persistent<NGInlineNode> inline_box_;
NGConstraintSpace* constraint_space_; // Not owned as STACK_ALLOCATED.
NGFragmentBuilder* containing_block_builder_;
- Vector<RefPtr<NGPhysicalFragment>, 32> fragments_;
- Vector<NGLogicalOffset, 32> offsets_;
Vector<LineBoxData, 32> line_box_data_list_;
unsigned start_index_ = 0;
unsigned start_offset_ = 0;
@@ -157,6 +155,8 @@ class CORE_EXPORT NGLineBuilder final {
LayoutUnit content_size_;
LayoutUnit max_inline_size_;
FontBaseline baseline_type_;
+ NGFragmentBuilder container_builder_;
+ RefPtr<NGLayoutResult> container_layout_result_;
NGLogicalOffset bfc_offset_;
NGLogicalRect current_opportunity_;

Powered by Google App Engine
This is Rietveld 408576698