Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 275373003: Remove --extra-chrome-flags command line switch. (Closed)

Created:
6 years, 7 months ago by Sungmann Cho
Modified:
6 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove --extra-chrome-flags command line switch. BUG=350233 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/test/base/test_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/test_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Sungmann Cho
Please take a look. Thanks!
6 years, 7 months ago (2014-05-11 06:00:51 UTC) #1
Sungmann Cho
ping...
6 years, 7 months ago (2014-05-13 21:47:58 UTC) #2
Paweł Hajdan Jr.
LGTM, thanks!
6 years, 7 months ago (2014-05-16 12:41:36 UTC) #3
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-16 12:43:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/275373003/1
6 years, 7 months ago (2014-05-16 12:43:36 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 16:15:36 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 17:11:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/27871)
6 years, 7 months ago (2014-05-16 17:11:14 UTC) #8
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-16 17:41:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/275373003/1
6 years, 7 months ago (2014-05-16 17:42:26 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 18:35:31 UTC) #11
Message was sent while issue was closed.
Change committed as 271066

Powered by Google App Engine
This is Rietveld 408576698