Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: base/trace_event/memory_dump_manager.cc

Issue 2753723003: Fix crash in InvokeOnMemoryDump when tracing (Closed)
Patch Set: be more explicit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_dump_manager.cc
diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc
index 5a54a773c5e4eb8b7eb816000855e23dc0374780..678c1c2397266e983ce96d7b3ebd99cab6a2e7a5 100644
--- a/base/trace_event/memory_dump_manager.cc
+++ b/base/trace_event/memory_dump_manager.cc
@@ -483,6 +483,18 @@ void MemoryDumpManager::RequestGlobalDump(
RequestGlobalDump(dump_type, level_of_detail, MemoryDumpCallback());
}
+bool MemoryDumpManager::IsDumpProviderRegisteredForTesting(
+ MemoryDumpProvider* provider) {
+ AutoLock lock(lock_);
+
+ auto mdp_iter = dump_providers_.begin();
Primiano Tucci (use gerrit) 2017/03/15 12:44:40 you can use C++11 foreach these days, which is qui
hjd 2017/03/15 14:23:12 Done, thanks!
+ for (; mdp_iter != dump_providers_.end(); ++mdp_iter) {
+ if ((*mdp_iter)->dump_provider == provider)
+ return true;
+ }
+ return false;
+}
+
void MemoryDumpManager::CreateProcessDump(const MemoryDumpRequestArgs& args,
const MemoryDumpCallback& callback) {
TRACE_EVENT_NESTABLE_ASYNC_BEGIN0(kTraceCategory, "ProcessMemoryDump",

Powered by Google App Engine
This is Rietveld 408576698