Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2753723002: Tweak location sdk summary is accessed from (Closed)

Created:
3 years, 9 months ago by Jacob
Modified:
3 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tweak location sdk summary is accessed from. Bazel build rules now place the sdk summary in a different directory than the summary root directory. Fix the ddc compiler running in the browser to match. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/2ec1890ac4a825059a138a2147e5fc0c35bf5ab3

Patch Set 1 #

Patch Set 2 : Fix for bug when binding non-symbolized members on native classes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 6 chunks +28 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
3 years, 9 months ago (2017-03-15 00:33:06 UTC) #2
vsm
lgtm
3 years, 9 months ago (2017-03-15 00:35:25 UTC) #3
Jacob
3 years, 9 months ago (2017-03-15 00:41:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2ec1890ac4a825059a138a2147e5fc0c35bf5ab3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698