Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java

Issue 2753713002: Remove ModerateBindingOnBackgroundTabCreation (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java b/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java
index 451abdbb0fba918090c484a6456cd0dd13d4cee3..beb3074d2bdaba8fca7b49cc82abad772bc16ceb 100644
--- a/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java
@@ -296,10 +296,9 @@ class BindingManagerImpl implements BindingManager {
*/
void determinedVisibility() {
if (!removeInitialBinding()) return;
-
- if (mModerateBindingTillBackgrounded) {
- addConnectionToModerateBindingPool(mConnection);
- }
+ // Decrease the likelihood of a recently created background tab getting evicted by
+ // immediately adding moderate binding.
+ addConnectionToModerateBindingPool(mConnection);
}
/**
@@ -339,10 +338,6 @@ class BindingManagerImpl implements BindingManager {
}
}
- // Whether a moderate binding should be added to a render process on process creation and
- // removed when Chrome is sent to the background.
- private boolean mModerateBindingTillBackgrounded;
-
// This can be manipulated on different threads, synchronize access on mManagedConnections.
private final SparseArray<ManagedConnection> mManagedConnections =
new SparseArray<ManagedConnection>();
@@ -488,13 +483,10 @@ class BindingManagerImpl implements BindingManager {
}
@Override
- public void startModerateBindingManagement(
- Context context, int maxSize, boolean moderateBindingTillBackgrounded) {
+ public void startModerateBindingManagement(Context context, int maxSize) {
if (mIsLowMemoryDevice) return;
ModerateBindingPool pool = new ModerateBindingPool(maxSize);
if (mModerateBindingPool.compareAndSet(null, pool)) {
- mModerateBindingTillBackgrounded = moderateBindingTillBackgrounded;
-
Log.i(TAG, "Moderate binding enabled: maxSize=%d", maxSize);
if (context != null) context.registerComponentCallbacks(pool);
}

Powered by Google App Engine
This is Rietveld 408576698