Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 27537012: Break core/platform/network dependency on core (Closed)

Created:
7 years, 2 months ago by abarth-chromium
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, Nate Chapin, adamk+blink_chromium.org, gavinp+loader_chromium.org
Visibility:
Public.

Description

Break core/platform/network dependency on core This CL breaks the last dependency from core/platform/network to the rest of core. I've moved FormDataList back to core and made it responsible for building FormData objects out of Blobs (and other items). That means FormData is not just data, which makes sense. After this CL and https://codereview.chromium.org/26283005/ land, we'll be able to move core/platform/network into blink_platform.dll. R=eseidel@chromium.org, eseidel BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159951

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -257 lines) Patch
M Source/core/core.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/DOMFormData.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/FormDataList.h View 2 chunks +6 lines, -0 lines 0 comments Download
A Source/core/html/FormDataList.cpp View 1 chunk +148 lines, -0 lines 0 comments Download
M Source/core/html/HTMLButtonElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseCheckableInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/HiddenInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/ImageInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/InputType.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/forms/SubmitInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FormSubmission.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/network/FormData.h View 1 4 chunks +2 lines, -5 lines 0 comments Download
M Source/core/platform/network/FormData.cpp View 1 3 chunks +0 lines, -98 lines 0 comments Download
D Source/core/platform/network/FormDataList.h View 1 chunk +0 lines, -86 lines 0 comments Download
D Source/core/platform/network/FormDataList.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSearchableFormData.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
abarth-chromium
7 years, 2 months ago (2013-10-17 20:44:57 UTC) #1
eseidel
lgtm
7 years, 2 months ago (2013-10-17 22:36:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/27537012/1
7 years, 2 months ago (2013-10-17 22:42:29 UTC) #3
commit-bot: I haz the power
Failed to trigger a try job on win_layout HTTP Error 400: Bad Request
7 years, 2 months ago (2013-10-17 23:49:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/27537012/2001
7 years, 2 months ago (2013-10-17 23:49:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/27537012/2001
7 years, 2 months ago (2013-10-18 08:27:30 UTC) #6
abarth-chromium
7 years, 2 months ago (2013-10-18 15:52:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r159951 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698