Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 27537009: Avoid always style recalc when removing stylesheets. (Closed)

Created:
7 years, 2 months ago by tasak
Modified:
7 years, 2 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears
Visibility:
Public.

Description

Avoid always style recalc when removing stylesheets. Replaced FullStyleUpdate with AnalyzedStyleUpdate when: - CSSStyleSheet::didMutate() is invoked from clearOwnerNode(). - StyleElement::removedFromDocument is invoked. Modified StyleSheetCollection::analyzeStyleSheetChange when stylesheet contents are just removed: - use Reset for StyleResolverUpdateType. - use StyleInvalidationAnalysis for style recalc. BUG=305885 TEST=All existing tests should pass after applying this patch. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159957

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add the virtual/* versions of add-keyframes to TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/animations/add-keyframes.html View 1 1 chunk +43 lines, -0 lines 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.cpp View 1 2 chunks +36 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tasak
I manually checked http://jsfiddle.net/GL4aE/ and confirmed that we could avoid style recalc.
7 years, 2 months ago (2013-10-17 09:34:08 UTC) #1
eseidel
lgtm https://codereview.chromium.org/27537009/diff/1/Source/core/css/resolver/StyleResolver.cpp File Source/core/css/resolver/StyleResolver.cpp (right): https://codereview.chromium.org/27537009/diff/1/Source/core/css/resolver/StyleResolver.cpp#newcode214 Source/core/css/resolver/StyleResolver.cpp:214: // FIXME: When chanking scoped attribute, scopingNode's hasScopedHTMLStyleChild ...
7 years, 2 months ago (2013-10-17 15:53:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/27537009/1
7 years, 2 months ago (2013-10-17 15:53:23 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=7979
7 years, 2 months ago (2013-10-17 19:37:48 UTC) #4
eseidel
Assuming it was a flake. The test does append a stylesheet so it's possible it's ...
7 years, 2 months ago (2013-10-17 20:20:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/27537009/1
7 years, 2 months ago (2013-10-17 20:28:31 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=8025
7 years, 2 months ago (2013-10-17 23:56:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/27537009/1
7 years, 2 months ago (2013-10-18 04:10:29 UTC) #8
commit-bot: I haz the power
Change committed as 159957
7 years, 2 months ago (2013-10-18 18:13:40 UTC) #9
eseidel
7 years, 2 months ago (2013-10-22 00:18:34 UTC) #10
Message was sent while issue was closed.
Bah.  Wrong issue.

Powered by Google App Engine
This is Rietveld 408576698