chrome/browser/android/physical_web/eddystone_encoder_bridge.h - Issue 2753683002: Build a Bridge to Eddystone Encoder in Components

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/physical_web/eddystone_encoder_bridge.h

Issue 2753683002: Build a Bridge to Eddystone Encoder in Components (Closed)

Patch Set: Personal Nits 1 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_ANDROID_EDDYSTONE_ENCODER_BRIDGE_H_
	Olivier 2017/03/17 08:53:02 Not sure this is enforced for Android, but guard i Not sure this is enforced for Android, but guard is missing PHYSICAL_WEB_
	6 #define CHROME_BROWSER_ANDROID_EDDYSTONE_ENCODER_BRIDGE_H_

	7

	8 #include <jni.h>

	9

	10 #include "base/android/jni_android.h"

	11 #include "base/android/scoped_java_ref.h"

	12

	13 using base::android::JavaParamRef;

	14

	15 bool RegisterEddystoneEncoderBridge(JNIEnv* env);

	16

	17 base::android::ScopedJavaLocalRef<jbyteArray> EncodeUrlForTesting(

	18 JNIEnv* env,

	19 const JavaParamRef<jobject>& jcaller,

	20 const JavaParamRef<jstring>& j_url);

	21

	22 #endif // CHROME_BROWSER_ANDROID_EDDYSTONE_ENCODER_BRIDGE_H_

OLD	NEW