Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: mojo/services/dbus_echo/dbus_echo_service.cc

Issue 275363002: Internalize ServiceConnector<> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add OnConnectionEstablished() Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/dbus_echo/dbus_echo_service.cc
diff --git a/mojo/services/dbus_echo/dbus_echo_service.cc b/mojo/services/dbus_echo/dbus_echo_service.cc
index f1f5cedd4dc0255aa41886e10d31e116d017db29..d725077240df744ff65471eafaeb0df550612eb9 100644
--- a/mojo/services/dbus_echo/dbus_echo_service.cc
+++ b/mojo/services/dbus_echo/dbus_echo_service.cc
@@ -16,12 +16,13 @@
#include "mojo/services/dbus_echo/echo.mojom.h"
namespace {
-class EchoServiceImpl
- : public mojo::ServiceConnection<mojo::EchoService, EchoServiceImpl> {
+class EchoServiceImpl : public mojo::InterfaceImpl<mojo::EchoService> {
public:
EchoServiceImpl() {}
virtual ~EchoServiceImpl() {}
+ virtual void OnConnectionError() OVERRIDE {}
+
protected:
virtual void Echo(
const mojo::String& in_to_echo,
@@ -29,6 +30,7 @@ class EchoServiceImpl
DVLOG(1) << "Asked to echo " << in_to_echo.To<std::string>();
callback.Run(in_to_echo);
}
+
darin (slow to review) 2014/05/15 18:06:20 nit: spurious new line
};
const char kServiceName[] = "org.chromium.EchoService";

Powered by Google App Engine
This is Rietveld 408576698