Internalize ServiceConnector<>

mojo/public/cpp/bindings/lib/interface_impl_internal.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_PUBLIC_CPP_BINDINGS_LIB_INTERFACE_IMPL_INTERNAL_H_
 #define MOJO_PUBLIC_CPP_BINDINGS_LIB_INTERFACE_IMPL_INTERNAL_H_
 
 #include "mojo/public/cpp/bindings/error_handler.h"
 #include "mojo/public/cpp/bindings/interface_ptr.h"
 #include "mojo/public/cpp/system/macros.h"
 
 namespace mojo {
 namespace internal {
 
+class InterfaceImplBase : public ErrorHandler {

[darin (slow to review), 2014/05/15 18:06:20]

I don't think this interface is needed. InterfaceImplState should just inherit
from ErrorHandler.

+ public:
+  virtual ~InterfaceImplBase() {}
+  virtual void OnConnectionEstablished() = 0;
+  virtual void OnConnectionError() = 0;
+};
+
+template <typename Base>
+class WithInterfaceImplBase : public Base {

[darin (slow to review), 2014/05/15 18:06:20]

This class should just be renamed InterfaceImplBase.

+ public:
+  virtual ~WithInterfaceImplBase() {}
+  virtual void OnConnectionEstablished() = 0;
+  virtual void OnConnectionError() = 0;
+};
+
 template <typename Interface>
-class InterfaceImplState : public ErrorHandler {
+class InterfaceImplState : public InterfaceImplBase {
  public:
   typedef typename Interface::Client Client;
 
-  explicit InterfaceImplState(WithErrorHandler<Interface>* instance)
+  explicit InterfaceImplState(WithInterfaceImplBase<Interface>* instance)
       : router_(NULL),
         client_(NULL),
         proxy_(NULL) {
     assert(instance);
     stub_.set_sink(instance);
   }
 
   virtual ~InterfaceImplState() {
     delete proxy_;
     if (router_) {
@@ skipping 14 matching lines @@
             MojoAsyncWaiter* waiter) {
     assert(!router_);
 
     router_ = new Router(handle.Pass(), waiter);
     router_->set_incoming_receiver(&stub_);
     router_->set_error_handler(this);
 
     proxy_ = new typename Client::Proxy_(router_);
 
     stub_.sink()->SetClient(proxy_);
+    OnConnectionEstablished();

[darin (slow to review), 2014/05/15 18:06:20]

no need for the virtual function call here. this can just be the code in
OnConnectionEstablished.

   }
 
   Router* router() { return router_; }
 
   void set_client(Client* client) { client_ = client; }
   Client* client() { return client_; }
 
  private:
+  virtual void OnConnectionEstablished() MOJO_OVERRIDE {
+    static_cast<WithInterfaceImplBase<Interface>*>(stub_.sink())->
+        OnConnectionEstablished();
+  }
+
   virtual void OnConnectionError() MOJO_OVERRIDE {
-    static_cast<WithErrorHandler<Interface>*>(stub_.sink())->
+    static_cast<WithInterfaceImplBase<Interface>*>(stub_.sink())->
         OnConnectionError();
   }
 
   internal::Router* router_;
   Client* client_;
   typename Client::Proxy_* proxy_;
   typename Interface::Stub_ stub_;
 
   MOJO_DISALLOW_COPY_AND_ASSIGN(InterfaceImplState);
 };
 
 }  // namespace internal
 }  // namespace mojo
 
 #endif  // MOJO_PUBLIC_CPP_BINDINGS_LIB_INTERFACE_IMPL_INTERNAL_H_