Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2753623002: Support iife heuristic in DDC (Closed)

Created:
3 years, 9 months ago by vsm
Modified:
3 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support iife heuristic in DDC This gives a noticeable 5-10% boost to startup on large internal apps in Chrome. We may want to consider for AMD at some point. It doesn't apply to es6 or common as those are top-level (and either the browser or linker would hopefully parse accordingly). R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/6fb0258bf4149552cffce0e7febbfe4d0961c12a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/module_builder.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/src/js_ast/nodes.dart View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vsm
3 years, 9 months ago (2017-03-14 19:33:49 UTC) #3
vsm
On 2017/03/14 19:33:49, vsm wrote: FYI, some background here - https://bugs.chromium.org/p/v8/issues/detail?id=5702
3 years, 9 months ago (2017-03-14 20:46:25 UTC) #4
Jennifer Messerly
lgtm
3 years, 9 months ago (2017-03-14 21:10:26 UTC) #5
vsm
3 years, 9 months ago (2017-03-14 21:16:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6fb0258bf4149552cffce0e7febbfe4d0961c12a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698