Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 27536003: Moved prefs::kUserPolicyRefreshRate to component/policy/policy_pref_names. (Closed)

Created:
7 years, 2 months ago by Joao da Silva
Modified:
7 years, 2 months ago
Reviewers:
dconnelly
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Moved prefs::kUserPolicyRefreshRate to component/policy/policy_pref_names. This removes a couple more DEPS exceptions from the policy code, and prepares it for the move into a component. Also renamed policy::prefs namespace to policy::policy_prefs, so that code in the policy namespace can refer both to policy_prefs:: and (global) prefs:: without having to prefix ::prefs::. Also removed a couple of obsolete DEPS exceptions. BUG=271392 R=dconnelly@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229339

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -53 lines) Patch
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud/DEPS View 1 3 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_core_unittest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_refresh_scheduler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/policy/policy_statistics_collector.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/policy_statistics_collector_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M components/policy/core/common/policy_pref_names.h View 1 1 chunk +6 lines, -4 lines 0 comments Download
M components/policy/core/common/policy_pref_names.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
PTAL
7 years, 2 months ago (2013-10-16 16:56:40 UTC) #1
dconnelly
lgtm
7 years, 2 months ago (2013-10-17 08:24:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/27536003/9001
7 years, 2 months ago (2013-10-17 11:07:46 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/common/pref_names.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-17 16:20:35 UTC) #4
Joao da Silva
7 years, 2 months ago (2013-10-18 09:52:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r229339 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698