Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: content/browser/background_fetch/background_fetch_context.h

Issue 2753583002: Add the JobComplete callback and error/interrupt information (Closed)
Patch Set: Missed two files because of rebasing, oops. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_context.h
diff --git a/content/browser/background_fetch/background_fetch_context.h b/content/browser/background_fetch/background_fetch_context.h
index 0ef5d6d7f3b6e4cb3f12992c66e4cdcc4da01254..dbf07c9fc00f1f6248a8485002e30e74fed1de47 100644
--- a/content/browser/background_fetch/background_fetch_context.h
+++ b/content/browser/background_fetch/background_fetch_context.h
@@ -58,6 +58,11 @@ class CONTENT_EXPORT BackgroundFetchContext
void CreateRequest(const BackgroundFetchJobInfo& job_info,
std::vector<BackgroundFetchRequestInfo>& request_infos);
+ // Callback for the JobController when the job is complete.
+ // TODO(harkness): Pass back enough information that the context can construct
+ // the Mojo response.
Peter Beverloo 2017/03/15 16:53:38 micro nit: I'd drop this TODO, it's not really set
harkness 2017/03/16 11:41:09 Done.
+ void JobComplete(const std::string& job_guid);
Peter Beverloo 2017/03/15 16:53:38 nit: We tend to name callbacks as DidCompleteJob o
harkness 2017/03/16 11:41:09 Done.
+
void ShutdownOnIO();
// |this| is owned by the BrowserContext via the StoragePartition.

Powered by Google App Engine
This is Rietveld 408576698