Add the JobComplete callback and error/interrupt information

content/browser/background_fetch/background_fetch_job_controller.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_JOB_CONTROLLER_H_
 #define CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_JOB_CONTROLLER_H_
 
 #include <memory>
 #include <string>
 #include <unordered_map>
 
+#include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/download_item.h"
 
 namespace content {
 
 class BackgroundFetchJobData;
 class BackgroundFetchRequestInfo;
 class BrowserContext;
 class StoragePartition;
 
 // The JobController will be responsible for coordinating communication with the
 // DownloadManager. It will get requests from the JobData and dispatch them to
 // the DownloadManager. It lives entirely on the IO thread.
 class CONTENT_EXPORT BackgroundFetchJobController
     : public DownloadItem::Observer {
  public:
-  BackgroundFetchJobController(
-      const std::string& job_guid,
-      BrowserContext* browser_context,
-      StoragePartition* storage_partition,
-      std::unique_ptr<BackgroundFetchJobData> job_data);
+  using JobCompleteCallback = base::Callback<void()>;

[Peter Beverloo, 2017/03/15 16:53:38]

base::OnceClosure. Can also drop the typedef that way.

[harkness, 2017/03/16 11:41:09]

I had hesitated on this based on the discussions around whether the events would
be combined, but I can always change it back if needed.

Done.

+
+  BackgroundFetchJobController(const std::string& job_guid,
+                               BrowserContext* browser_context,
+                               StoragePartition* storage_partition,
+                               std::unique_ptr<BackgroundFetchJobData> job_data,
+                               const JobCompleteCallback& callback);

[Peter Beverloo, 2017/03/15 16:53:38]

nit: drop const& if you can use OnceClosure and std::move() instead

[Peter Beverloo, 2017/03/15 16:53:38]

nit: completed_callback?

[harkness, 2017/03/16 11:41:09]

Done.

[harkness, 2017/03/16 11:41:09]

Done.

   ~BackgroundFetchJobController() override;
 
   // Start processing on a batch of requests. Some of these may already be in
   // progress or completed from a previous chromium instance.
   void StartProcessing();
 
   // Called by the BackgroundFetchContext when the system is shutting down.
   void Shutdown();
 
  private:
@@ skipping 15 matching lines @@
   // Investigate whether the DownloadManager should be passed instead.
   BrowserContext* browser_context_;
 
   // Pointer to the storage partition. This object is owned by the partition
   // (through a sequence of other classes).
   StoragePartition* storage_partition_;
 
   // The JobData which talks to the DataManager for this job_guid.
   std::unique_ptr<BackgroundFetchJobData> job_data_;
 
+  // Callback for when all fetches have been completed.
+  JobCompleteCallback callback_;
+
   // Map from the GUID assigned by the DownloadManager to the request_guid.
   std::unordered_map<std::string, std::string> download_guid_map_;
 
   base::WeakPtrFactory<BackgroundFetchJobController> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BackgroundFetchJobController);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_JOB_CONTROLLER_H_