Add the JobComplete callback and error/interrupt information

content/browser/background_fetch/background_fetch_context.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/background_fetch/background_fetch_context.h"
 
 #include "content/browser/background_fetch/background_fetch_job_info.h"
 #include "content/browser/background_fetch/background_fetch_request_info.h"
 #include "content/browser/service_worker/service_worker_context_wrapper.h"
 #include "content/public/browser/browser_context.h"
@@ skipping 50 matching lines @@
   // Inform the data manager about the new download.
   std::unique_ptr<BackgroundFetchJobData> job_data =
       background_fetch_data_manager_.CreateRequest(job_info, request_infos);
 
   // If job_data is null, the DataManager will have logged an error.
   if (job_data) {
     // Create a controller which drives the processing of the job. It will use
     // the JobData to get information about individual requests for the job.
     job_map_[job_info.guid()] = base::MakeUnique<BackgroundFetchJobController>(
         job_info.guid(), browser_context_, storage_partition_,
-        std::move(job_data));
+        std::move(job_data),
+        base::Bind(&BackgroundFetchContext::JobComplete, this,
+                   job_info.guid()));

[Peter Beverloo, 2017/03/15 16:53:38]

We need to clear job_map_ in ShutdownOnIO. This creates a reference cycle
that'll make it impossible to delete BackgroundFetchContext if there are active
jobs, which in turn violates all sorts of assumptions (e.g. availability of the
other Profile-bound objects).

[harkness, 2017/03/16 11:41:09]

Done.

   }
 }
 
+void BackgroundFetchContext::JobComplete(const std::string& job_guid) {
+  DCHECK(job_map_.find(job_guid) != job_map_.end());
+
+  // TODO(harkness): Get enough data to send the response back to the
+  // caller.

[Peter Beverloo, 2017/03/15 16:53:38]

micro nit: same re: the TODO

[harkness, 2017/03/16 11:41:09]

Done.

+
+  job_map_.erase(job_guid);
+
+  // TODO(harkness): Once the caller receives the message, inform the
+  // DataManager that it can clean up the pending job.
+}
+
 }  // namespace content