Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2753553002: Parse empty statements with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 2 chunks +0 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 9 months ago (2017-03-14 17:50:30 UTC) #1
Paul Berry
lgtm
3 years, 9 months ago (2017-03-14 17:51:49 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 9cf7535e0306230aa81f5ae998c5716c0f9afca5 (presubmit successful).
3 years, 9 months ago (2017-03-14 18:35:31 UTC) #4
ahe
3 years, 9 months ago (2017-03-16 14:33:10 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698