WebRTC: Use the MediaStream Recording API for the audio_quality_browsertest.

chrome/browser/media/webrtc/webrtc_browsertest_common.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/webrtc/webrtc_browsertest_common.h"
 
 #include "base/files/file_util.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
@@ skipping 101 matching lines @@
   const std::string javascript = base::StringPrintf(
       "setTimeout(function() {"
       "  window.domAutomationController.send('sleep-ok');"
       "}, %d)", timeout_msec);
 
   std::string result;
   bool ok = content::ExecuteScriptAndExtractString(
       tab_contents, javascript, &result);
   return ok && result == "sleep-ok";
 }
-
 bool PollingWaitUntil(const std::string& javascript,
                       const std::string& evaluates_to,
                       content::WebContents* tab_contents) {
   return PollingWaitUntil(javascript, evaluates_to, tab_contents,
                           kDefaultPollIntervalMsec);
 }
 
 bool PollingWaitUntil(const std::string& javascript,
                       const std::string& evaluates_to,
                       content::WebContents* tab_contents,
                       int poll_interval_msec) {
   base::Time start_time = base::Time::Now();
   base::TimeDelta timeout = TestTimeouts::action_max_timeout();
   std::string result;
 
   while (base::Time::Now() - start_time < timeout) {
-    std::string result;
     if (!content::ExecuteScriptAndExtractString(tab_contents, javascript,
                                                 &result)) {
       LOG(ERROR) << "Failed to execute javascript " << javascript;
       return false;
     }
 
     if (evaluates_to == result) {
       return true;
     } else if (IsErrorResult(result)) {
       LOG(ERROR) << "|" << javascript << "| returned an error: " << result;
       return false;
     }
 
     // Sleep a bit here to keep this loop from spinlocking too badly.
     if (!SleepInJavascript(tab_contents, poll_interval_msec)) {
       // TODO(phoglund): Figure out why this fails every now and then.
       // It's not a huge deal if it does though.
       LOG(ERROR) << "Failed to sleep.";
     }
   }
   LOG(ERROR)
       << "Timed out while waiting for " << javascript
       << " to evaluate to " << evaluates_to << "; last result was '" << result
       << "'";
   return false;
 }
 
+bool PollingWaitUntil(const std::string& javascript,
+                      content::WebContents* tab_contents,
+                      int poll_interval_msec) {
+  base::Time start_time = base::Time::Now();
+  base::TimeDelta timeout = TestTimeouts::action_max_timeout();
+  bool result;
+
+  while (base::Time::Now() - start_time < timeout) {
+    if (!content::ExecuteScriptAndExtractBool(tab_contents, javascript,
+                                              &result)) {
+      LOG(ERROR) << "Failed to execute javascript " << javascript;
+      return false;
+    }
+
+    if (result) {
+      return true;
+    }
+
+    // Sleep a bit here to keep this loop from spinlocking too badly.
+    if (!SleepInJavascript(tab_contents, poll_interval_msec)) {
+      // TODO(phoglund): Figure out why this fails every now and then.
+      // It's not a huge deal if it does though.
+      LOG(ERROR) << "Failed to sleep.";
+    }
+  }
+  LOG(ERROR) << "Timed out while waiting for " << javascript;
+  return false;
+}

[mcasas, 2017/03/22 17:54:14]

This code is very similar to l.129-163. Either refactor
the common parts or do something like :

bool PollingWaitUntil(const std::string& javascript,
                      content::WebContents* tab_contents,
                      int poll_interval_msec) {
  return PollingWaitUntil(javascript, "true", tab_contents, poll_interval_msec);
}

(since you can't have default value for parameters
in the middle of the parameter list).

You might need to return doneCapturing.toString()
in audio_extraction.js l.61.

+
 }  // namespace test